gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat: CSS Cafe Menu (#41797)

Browse Source 
* fix: general bugs

- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.

* feat: some tests

* feat: tests 6-20

Add tests for steps 6-20.

* feat: tests 21-30

Add tests for steps 21 through 30.

* feat: tests 31-40

Add tests for steps 31 through 40.

* feat: tests 41-50

Add tests for steps 41 through 50.

* feat: tests 51-60

Add tests for steps 51 through 60.

* feat: tests 61-70

Add tests for steps 61 through 70.

* feat: tests 71-80

Add tests for steps 71 through 80.

* feat: steps 81-92

Add tests for steps 81 through 92.

* feat: align dashed names

Align the dashed names with the titles and file names.

* fix: apply gikf's suggestions

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: manual review suggestions

Apply gikf's other suggestions.

* feat: more thorough testing

When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.

* feat: optional semi colons

Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?

* chore: apply review suggestions

Apply review suggestions from gikf

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* chore: apply suggestions from code review

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* feat: review suggestions

Apply Ahmad's review suggestions.

* chore: additional suggestions

Manual application of Ahmad's review suggestions.

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* feat: add clarification

Add a bit of text clarifying the file switch in the editor.

* chore: replace URLs

Replace the tinyurls with our self-hosted CDN images.

* feat: new CSS tests

Re-write CSS tests with new parser.

* fix: grammar

Apply Shaun's grammar reviews.

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: optional chaining

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply reviews manually

* chore: getStyle update

Replace getStyleDeclaration with getStyle.

* fix: resolve test issue

* chore: remove jQuery :(

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
This commit is contained in:
Nicholas Carrigan (he/him)
2021-07-21 12:03:09 -07:00
committed by GitHub
parent 0e611f321e
commit 8900fe0b8e
94 changed files with 2214 additions and 937 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
curriculum/challenges/_meta/basic-css-cafe-menu/meta.json
View File

@@ -223,163 +223,159 @@
"Part 53"
],
[
"5f3ef6e0086dc80481f8cb03",
"5f3ef6e0eaa7da26e3d34d78",
"Part 54"
],
[
"5f3ef6e0eaa7da26e3d34d78",
"5f3ef6e050279c7a4a7101d3",
"Part 55"
],
[
"5f3ef6e050279c7a4a7101d3",
"5f3ef6e04559b939080db057",
"Part 56"
],
[
"5f3ef6e04559b939080db057",
"5f3ef6e03d719d5ac4738993",
"Part 57"
],
[
"5f3ef6e03d719d5ac4738993",
"5f3ef6e05473f91f948724ab",
"Part 58"
],
[
"5f3ef6e05473f91f948724ab",
"5f3ef6e056bdde6ae6892ba2",
"Part 59"
],
[
"5f3ef6e056bdde6ae6892ba2",
"5f3ef6e0e9629bad967cd71e",
"Part 60"
],
[
"5f3ef6e0e9629bad967cd71e",
"5f3ef6e06d34faac0447fc44",
"Part 61"
],
[
"5f3ef6e06d34faac0447fc44",
"5f3ef6e087d56ed3ffdc36be",
"Part 62"
],
[
"5f3ef6e087d56ed3ffdc36be",
"5f3ef6e0f8c230bdd2349716",
"Part 63"
],
[
"5f3ef6e0f8c230bdd2349716",
"5f3ef6e07276f782bb46b93d",
"Part 64"
],
[
"5f3ef6e07276f782bb46b93d",
"5f3ef6e0a81099d9a697b550",
"Part 65"
],
[
"5f3ef6e0a81099d9a697b550",
"5f3ef6e0b431cc215bb16f55",
"Part 66"
],
[
"5f3ef6e0b431cc215bb16f55",
"5f3ef6e01f288a026d709587",
"Part 67"
],
[
"5f3ef6e01f288a026d709587",
"5f3f26fa39591db45e5cd7a0",
"Part 68"
],
[
"5f3f26fa39591db45e5cd7a0",
"5f459225127805351a6ad057",
"Part 69"
],
[
"5f459225127805351a6ad057",
"5f459a7ceb8b5c446656d88b",
"Part 70"
],
[
"5f459a7ceb8b5c446656d88b",
"5f459cf202c2a3472fae6a9f",
"Part 71"
],
[
"5f459cf202c2a3472fae6a9f",
"5f459fd48bdc98491ca6d1a3",
"Part 72"
],
[
"5f459fd48bdc98491ca6d1a3",
"5f45a05977e2fa49d9119437",
"Part 73"
],
[
"5f45a05977e2fa49d9119437",
"5f45a276c093334f0f6e9df4",
"Part 74"
],
[
"5f45a276c093334f0f6e9df4",
"5f45a5a7c49a8251f0bdb527",
"Part 75"
],
[
"5f45a5a7c49a8251f0bdb527",
"5f46fc57528aa1c4b5ea7c2e",
"Part 76"
],
[
"5f46fc57528aa1c4b5ea7c2e",
"5f4701b942c824109626c3d8",
"Part 77"
],
[
"5f4701b942c824109626c3d8",
"5f46ede1ff8fec5ba656b44c",
"Part 78"
],
[
"5f46ede1ff8fec5ba656b44c",
"5f45a66d4a2b0453301e5a26",
"Part 79"
],
[
"5f45a66d4a2b0453301e5a26",
"5f45b0731d39e15d54df4dfc",
"Part 80"
],
[
"5f45b0731d39e15d54df4dfc",
"5f45b25e7ec2405f166b9de1",
"Part 81"
],
[
"5f45b25e7ec2405f166b9de1",
"5f45b3c93c027860d9298dbd",
"Part 82"
],
[
"5f45b3c93c027860d9298dbd",
"5f45b45d099f3e621fbbb256",
"Part 83"
],
[
"5f45b45d099f3e621fbbb256",
"5f45b4c81cea7763550e40df",
"Part 84"
],
[
"5f45b4c81cea7763550e40df",
"5f45b715301bbf667badc04a",
"Part 85"
],
[
"5f45b715301bbf667badc04a",
"5f46e270702a8456a664f0df",
"Part 86"
],
[
"5f46e270702a8456a664f0df",
"5f46e36e745ead58487aabf2",
"Part 87"
],
[
"5f46e36e745ead58487aabf2",
"5f46e7a4750dd05b5a673920",
"Part 88"
],
[
"5f46e7a4750dd05b5a673920",
"5f46e8284aae155c83015dee",
"Part 89"
],
[
"5f46e8284aae155c83015dee",
"5f475bb508746c16c9431d42",
"Part 90"
],
[
"5f475bb508746c16c9431d42",
"5f475e1c7f71a61d913836c6",
"Part 91"
],
[
"5f475e1c7f71a61d913836c6",
"Part 92"
],
[
"5f47fe7e31980053a8d4403b",
"Part 93"
"Part 92"
]
]}