From 891a64fa3dd8c8d950e0011c0eabf2690476b480 Mon Sep 17 00:00:00 2001 From: "Nicholas Carrigan (he/him)" Date: Wed, 20 Jan 2021 20:57:32 -0800 Subject: [PATCH] fix(learn): Remove arrows from test name assertion (#40467) * fix: Remove arrows from test name assertion Signed-off-by: nhcarrigan * fix: Add note about time span Adds a note regarding the expectation of the `span` element to wrap the entire time string when translated, not just the delimiter symbol. Signed-off-by: nhcarrigan * fix: use correct note syntax Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * fix: remove note syntax New line was breaking the build, so changing the `note` comment to be regular text. Signed-off-by: nhcarrigan Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> --- .../american-british-translator.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md b/curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md index 0387656d3d..c2e5448f12 100644 --- a/curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md +++ b/curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md @@ -102,7 +102,7 @@ async (getUserInput) => { }; ``` -The `/api/translate` route should handle the way time is written in American and British English. For example, ten thirty is written as "10.30" in British English and "10:30" in American English. +The `/api/translate` route should handle the way time is written in American and British English. For example, ten thirty is written as "10.30" in British English and "10:30" in American English. The `span` element should wrap the entire time string, i.e. `10:30`. ```js async (getUserInput) => { @@ -283,7 +283,7 @@ async (getUserInput) => { const getTests = await $.get(getUserInput('url') + '/_api/get-tests'); assert.isArray(getTests); const unitTests = getTests.filter((test) => { - return !!test.context.match(/Unit Tests ->/gi); + return !!test.context.match(/Unit Tests/gi); }); assert.isAtLeast(unitTests.length, 24, 'At least 24 tests passed'); unitTests.forEach((test) => { @@ -308,7 +308,7 @@ async (getUserInput) => { const getTests = await $.get(getUserInput('url') + '/_api/get-tests'); assert.isArray(getTests); const functTests = getTests.filter((test) => { - return !!test.context.match(/Functional Tests ->/gi); + return !!test.context.match(/Functional Tests/gi); }); assert.isAtLeast(functTests.length, 6, 'At least 6 tests passed'); functTests.forEach((test) => {