gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix: largestPrimeFactor function, Add: largestPrimeFactor(8) test (#38756)

Browse Source 
* Fix `largestPrimeFactor(8)` result
* Improve `largestPrimeFactor` performance
* Add `largestPrimeFactor(8)` test
This commit is contained in:
Rostyslav Ugryniuk
2020-05-07 21:31:59 +03:00
committed by GitHub
parent 7126bacf34
commit 8a858b470c
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-3-largest-prime-factor.english.md
View File

@ -34,6 +34,8 @@ tests:
testString: assert.strictEqual(largestPrimeFactor(5), 5); testString: assert.strictEqual(largestPrimeFactor(5), 5);
- text: <code>largestPrimeFactor(7)</code> should return 7. - text: <code>largestPrimeFactor(7)</code> should return 7.
testString: assert.strictEqual(largestPrimeFactor(7), 7); testString: assert.strictEqual(largestPrimeFactor(7), 7);
- text: <code>largestPrimeFactor(8)</code> should return 2.
testString: assert.strictEqual(largestPrimeFactor(8), 2);
- text: <code>largestPrimeFactor(13195)</code> should return 29. - text: <code>largestPrimeFactor(13195)</code> should return 29.
testString: assert.strictEqual(largestPrimeFactor(13195), 29); testString: assert.strictEqual(largestPrimeFactor(13195), 29);
- text: <code>largestPrimeFactor(600851475143)</code> should return 6857. - text: <code>largestPrimeFactor(600851475143)</code> should return 6857.
@ -68,14 +70,18 @@ largestPrimeFactor(13195);
```js ```js
const largestPrimeFactor = (number)=>{ const largestPrimeFactor = (number) => {
let largestFactor = number; let largestFactor = number;
for(let i = 2;i<largestFactor;i++){
if(!(largestFactor%i)){ for (let i = 2; i <= Math.sqrt(largestFactor); i++) {
largestFactor = largestFactor/i; if (!(largestFactor % i)) {
largestPrimeFactor(largestFactor); let factor = largestFactor / i;
} let candidate = largestPrimeFactor(factor);
return i > candidate ? i : candidate;
}
} }
return largestFactor; return largestFactor;
} }
``` ```