From 8e5b99b8cab9506d32f3ec4b6535698c95db484e Mon Sep 17 00:00:00 2001 From: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Date: Tue, 5 Mar 2019 05:57:48 -0800 Subject: [PATCH] fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367) * fix: prevent 5th test from allowing invalid code * fix: added new test to not allow extra characters --- .../escape-sequences-in-strings.english.md | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md index 16f35e701a..cdeccef81b 100644 --- a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md +++ b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md @@ -27,17 +27,19 @@ Here is the text with the escape sequences written out. ```yml tests: - text: myStr should not contain any spaces - testString: assert(!/ /.test(myStr), 'myStr should not contain any spaces'); + testString: assert(!/ /.test(myStr)); - text: myStr should contain the strings FirstLine, SecondLine and ThirdLine (remember case sensitivity) - testString: assert(/FirstLine/.test(myStr) && /SecondLine/.test(myStr) && /ThirdLine/.test(myStr), 'myStr should contain the strings FirstLine, SecondLine and ThirdLine (remember case sensitivity)'); + testString: assert(/FirstLine/.test(myStr) && /SecondLine/.test(myStr) && /ThirdLine/.test(myStr)); - text: FirstLine should be followed by the newline character \n - testString: assert(/FirstLine\n/.test(myStr), 'FirstLine should be followed by the newline character \n'); + testString: assert(/FirstLine\n/.test(myStr)); - text: myStr should contain a tab character \t which follows a newline character - testString: assert(/\n\t/.test(myStr), 'myStr should contain a tab character \t which follows a newline character'); - - text: SecondLine should be preceded by the backslash character \\ - testString: assert(/\SecondLine/.test(myStr), 'SecondLine should be preceded by the backslash character \\'); + testString: assert(/\n\t/.test(myStr)); + - text: SecondLine should be preceded by the backslash character \ + testString: assert(/\\SecondLine/.test(myStr)); - text: There should be a newline character between SecondLine and ThirdLine - testString: assert(/SecondLine\nThirdLine/.test(myStr), 'There should be a newline character between SecondLine and ThirdLine'); + testString: assert(/SecondLine\nThirdLine/.test(myStr)); + - text: myStr should only contain characters shown in the instructions + testString: assert(myStr === 'FirstLine\n\t\\SecondLine\nThirdLine'); ```