Merge pull request #10181 from BerkeleyTrue/fix/user-sensitive-routes

Fix(routes): user sensitive routes redirect to map

common/app/create-app.jsx

@@ -5,7 +5,7 @@ import { compose, createStore, applyMiddleware } from 'redux';
 // main app
 import App from './App.jsx';
 // app routes
-import childRoutes from './routes';
+import createChildRoute from './routes';
 
 // redux
 import { createEpic } from 'redux-epic';
@@ -17,8 +17,6 @@ import servicesCreator from '../utils/services-creator';
 
 const createRouteProps = Observable.fromNodeCallback(match);
 
-const routes = { components: App, ...childRoutes };
-
 //
 // createApp(settings: {
 //   location?: Location|String,
@@ -75,7 +73,12 @@ export default function createApp({
   // sync history client side with store.
   // server side this is an identity function and history is undefined
   history = syncHistoryWithStore(history, store, syncOptions);
-
+  const routes = {
+    components: App,
+    ...createChildRoute({
+      getState() { return store.getState(); }
+    })
+  };
   // createRouteProps({
   //   redirect: LocationDescriptor,
   //   history: History,

common/app/routes/challenges/index.js

@@ -1,7 +1,8 @@
 import Show from './components/Show.jsx';
-import Map from './components/map/Map.jsx';
+import ShowMap from './components/map/Map.jsx';
 
-export const challenges = {
+export function challengesRoute() {
+  return {
     path: 'challenges(/:dashedName)',
     component: Show,
     onEnter(nextState, replace) {
@@ -10,14 +11,19 @@ export const challenges = {
         replace('/map');
       }
     }
-};
+  };
+}
 
-export const modernChallenges = {
+export function modernChallengesRoute() {
+  return {
     path: 'challenges/:block/:dashedName',
     component: Show
-};
+  };
+}
 
-export const map = {
+export function mapRoute() {
+  return {
     path: 'map',
-  component: Map
+    component: ShowMap
-};
+  };
+}

common/app/routes/index.js

@@ -1,9 +1,14 @@
-import { modernChallenges, map, challenges } from './challenges';
+import {
+  modernChallengesRoute,
+  mapRoute,
+  challengesRoute
+} from './challenges';
 import NotFound from '../components/NotFound/index.jsx';
 import { addLang } from '../utils/lang';
-import settings from './settings';
+import settingsRoute from './settings';
 
-export default {
+export default function createChildRoute(deps) {
+  return {
     path: '/:lang',
     indexRoute: {
       onEnter(nextState, replace) {
@@ -13,13 +18,14 @@ export default {
       }
     },
     childRoutes: [
-    challenges,
+      challengesRoute(deps),
-    modernChallenges,
+      modernChallengesRoute(deps),
-    map,
+      mapRoute(deps),
-    settings,
+      settingsRoute(deps),
       {
         path: '*',
         component: NotFound
       }
     ]
-};
+  };
+}

common/app/routes/settings/index.js

@@ -1,10 +1,19 @@
 import Settings from './components/Settings.jsx';
-import updateEmail from './routes/update-email';
+import updateEmailRoute from './routes/update-email';
 
-export default {
+export default function settingsRoute(deps) {
+  const { getState } = deps;
+  return {
     path: 'settings',
     component: Settings,
+    onEnter(nextState, replace) {
+      const { app: { user } } = getState();
+      if (!user) {
+        replace('/map');
+      }
+    },
     childRoutes: [
-    updateEmail
+      updateEmailRoute(deps)
     ]
-};
+  };
+}

common/app/routes/settings/routes/update-email/index.js

@@ -1,6 +1,8 @@
 import UpdateEmail from './Update-Email.jsx';
 
-export default {
+export default function updateEmailRoute() {
+  return {
     path: 'update-email',
     component: UpdateEmail
-};
+  };
+}