fix: return the loader after redirect (#37432)

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2019-10-22 14:28:35 +03:00
parent afeb476818
commit 9337d6ad82
5 changed files with 48 additions and 15 deletions
--- a/client/src/client-only-routes/ShowSettings.js
+++ b/client/src/client-only-routes/ShowSettings.js
@@ -162,14 +162,13 @@ export function ShowSettings(props) {
  }

  if (!showLoading && !isSignedIn) {
-    return navigate(`${apiLocation}/signin?returnTo=settings`);
+    navigate(`${apiLocation}/signin?returnTo=settings`);
+    return <Loader fullScreen={true} />;
  }

  return (
    <Fragment>
-      <Helmet>
-        <title>Settings | freeCodeCamp.org</title>
-      </Helmet>
+      <Helmet title='Settings | freeCodeCamp.org'></Helmet>
      <Grid>
        <main>
          <Spacer size={2} />