gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client,server): usernames should not be a http error code (#37804)

Browse Source 
* fix(client,server): usernames should not be a http error code
* feat: reject invalid chars first

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
mrugesh
2019-11-27 10:49:17 +05:30
committed by GitHub
parent b7949087e3
commit 9886cf7ca2
4 changed files with 53 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api-server/server/boot/settings.js
View File

@ -4,7 +4,7 @@ import { check } from 'express-validator/check';
import { ifNoUser401, createValidatorErrorHandler } from '../utils/middleware';
import { themes } from '../../common/utils/themes.js';
import { alertTypes } from '../../common/utils/flash.js';
import { validate } from '../../../utils/validate';
import { isValidUsername } from '../../../utils/validate';
const log = debug('fcc:boot:settings');
@ -200,7 +200,7 @@ function createUpdateMyUsername(app) {
message: 'Username is already associated with this account'
});
}
const validation = validate(username);
const validation = isValidUsername(username);
if (!validation.valid) {
return res.json({