From 98d9e7874f3da8cd42abbac81044eda1ff64f455 Mon Sep 17 00:00:00 2001 From: Randell Dawson Date: Fri, 9 Nov 2018 15:52:30 -0800 Subject: [PATCH] fix: corrected guide error logic --- labelOpenPrs.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/labelOpenPrs.js b/labelOpenPrs.js index d25f929e19..1ef195c71d 100644 --- a/labelOpenPrs.js +++ b/labelOpenPrs.js @@ -59,15 +59,15 @@ const prPropsToGet = ['number', 'labels', 'user']; const [ _, first, second ] = filenameReplacement.match(regex) || []; // need an array to pass to labelsAdder if (first && validLabels[first]) { labelsToAdd[validLabels[first]] = 1 } if (second && validLabels[second]) { labelsToAdd[validLabels[second]] = 1 } + + const guideFolderErrorsComment = guideFolderChecks(filename, username); + + if (guideFolderErrorsComment) { + addComment(number, guideFolderErrorsComment); + labelsToAdd['status: needs update'] = 1; + } }) - const guideFolderErrorsComment = guideFolderChecks(filename, username); - - if (guideFolderErrors) { - addComment(number, guideFolderErrorsComment); - labelsToAdd['status: needs update'] = 1; - } - labelsAdder(number, existingLabels, labelsToAdd, log); } else {