gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(dashboard): Use CDN for favicon (#40522)

Browse Source 
* fix: Use CDN for favicon

Replaces the local favicon (which was not
rendering correctly on production) with the
version served by the CDN. Also adds our other
meta tags used for PWAs and OpenGraph Protocol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove local manifest

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
This commit is contained in:
Nicholas Carrigan (he/him)
2020-12-22 16:07:21 -08:00
committed by GitHub
parent 0ff001eaed
commit 994598900a
3 changed files with 48 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
tools/contributor/dashboard-app/client/public/favicon.ico
View File

Binary file not shown.
Side by Side

Before

Width:  |  Height:  |  Size: 7.2 KiB

70
tools/contributor/dashboard-app/client/public/index.html
View File

@ -2,22 +2,56 @@
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<link rel="shortcut icon" href="favicon.ico">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<meta name="theme-color" content="#000000"> <meta name="theme-color" content="#000000">
<!-- <meta
manifest.json provides metadata used when your web app is added to the content="https://cdn.freecodecamp.org/platform/universal/fcc_meta_1920x1080-indigo.png"
homescreen on Android. See https://developers.google.com/web/fundamentals/web-app-manifest/ name="og:image"
--> />
<link rel="manifest" href="manifest.json"> <meta content="freeCodeCamp Contributor Tools" name="twitter:title" />
<!-- <meta
Notice the use of %PUBLIC_URL% in the tags above. content="Tools for contributors working on the freeCodeCamp curriculum."
It will be replaced with the URL of the `public` folder during the build. name="og:description"
Only files inside the `public` folder can be referenced from the HTML. />
Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will <meta content="a40ee5d5dba3bb091ad783ebd2b1383f" name="p:domain_verify" />
work correctly both with client-side routing and a non-root public URL. <meta content="#FFFFFF" name="msapplication-TileColor" />
Learn how to configure a non-root public URL by running `npm run build`. <meta
--> content="https://cdn.freecodecamp.org/universal/favicons/browserconfig.xml"
rel="msapplication-config"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/android-chrome-192x192.png"
rel="android-chrome"
sizes="192x192"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/android-chrome-384x384.png"
rel="android-chrome"
sizes="384x384"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/site.webmanifest"
rel="manifest"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/apple-touch-icon.png"
rel="apple-touch-icon"
sizes="180x180"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/favicon-16x16.png"
rel="favicon"
sizes="16x16"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/favicon-32x32.png"
rel="favicon"
sizes="32x32"
/>
<link
href="https://cdn.freecodecamp.org/universal/favicons/favicon.ico"
rel="icon"
/>
<title>freeCodeCamp Contributor Tools</title> <title>freeCodeCamp Contributor Tools</title>
</head> </head>
<body> <body>
@ -25,13 +59,5 @@
You need to enable JavaScript to run this app. You need to enable JavaScript to run this app.
</noscript> </noscript>
<div id="root"></div> <div id="root"></div>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.
You can add webfonts, meta tags, or analytics to this file.
The build step will place the bundled scripts into the <body> tag.
To begin the development, run `npm start` or `yarn start`.
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body> </body>
</html> </html>

15
tools/contributor/dashboard-app/client/public/manifest.json
View File

@ -1,15 +0,0 @@
{
"short_name": "FCC Contribute",
"name": "Free Code Camp Contribute",
"icons": [
{
"src": "favicon.ico",
"sizes": "64x64 32x32 24x24 16x16",
"type": "image/x-icon"
}
],
"start_url": ".",
"display": "standalone",
"theme_color": "#000000",
"background_color": "#ffffff"
}