diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index d815bfdb4a..0000000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,18 +0,0 @@ - - -#### Describe your problem and - if possible - how to reproduce it - - -#### Add a Link to the page with the problem - - -#### Tell us about your browser and operating system - -* Browser Name: -* Browser Version: -* Operating System: - - -#### If possible, add a screenshot here - - diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 380d3f4e58..e791d751b9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,32 +1,62 @@ - + - - +Before creating a PR, please make sure to verify the following by marking the checkboxes below as complete. -#### Pre-Submission Checklist - - - -- [ ] Your pull request targets the `staging` branch of freeCodeCamp. -- [ ] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`) -- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit). -- [ ] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes. +- [x] Like this! -#### Type of Change - -- [ ] Small bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds new functionality) -- [ ] Breaking change (fix or feature that would change existing functionality) -- [ ] Add new translation (feature adding new translations) +--> -#### Checklist: - - -- [ ] Tested changes locally. -- [ ] Addressed currently open issue (replace XXXXX with an issue no in next line) +### Description + + + + + + +### Pre-Submission Checklist +**By submitting this pull request, I have verified the following:** + +- [ ] Added descriptive name to pull request. + +Your PR should NOT be called `Update index.md`, since it does not help the maintainer understand what has been changed. + +Good Guide PR title examples: + +```txt +fix(guide): Git - edit Git Commit article +feat(guide): PHP - create PHP section and add Data Structures article +``` + +Good Coding challenge PR title examples: + +```txt +fix(coding): add tests to Basic HTML challenge +fix(coding): update instructions to CSS Grid challenge +``` + +#### This change is for the Learning platform or Coding Challenges, and: + +- [ ] I tested my changes by running freeCodeCamp locally. +- [ ] All new and existing tests pass the command `npm test`. + +#### This change is for Guide Articles, and: + +- [ ] I confirm no **plagiarized**, **duplicate**, or **repetitive content** that has been directly copied from another source. +- [ ] I am adding only `https` links to external sources. +- [ ] I am not adding short links instead of full URLs to webpages. + +#### Common requirements + +- [ ] This pull request targets the `master` branch of freeCodeCamp. +- [ ] Branch starts with either `fix/`, `feature/`, or `translate/` + (e.g. `fix/signin-issue`) +- [ ] I reviewed necessary formatting guidelines in [`CONTRIBUTING.md`](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md). + +### Issues Closures + +- [ ] Addressed currently open issue. (replace XXXXX with an issue no in next line) Closes #XXXXX -#### Description - +**(Optional) Additional Context and Screenshots:** + \ No newline at end of file