From 9ad4c98ecb5f7571ac01f88b38c10bb884747e65 Mon Sep 17 00:00:00 2001 From: Shaun Hamilton <51722130+Sky020@users.noreply.github.com> Date: Mon, 18 May 2020 15:02:03 +0100 Subject: [PATCH] fix(curriculum): added test to allow any order solution (#38771) * added test to allow any order solution * add removeJSComments for tests --- .../problem-43-sub-string-divisibility.english.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-43-sub-string-divisibility.english.md b/curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-43-sub-string-divisibility.english.md index 78cc22631f..3afeca67e3 100644 --- a/curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-43-sub-string-divisibility.english.md +++ b/curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-43-sub-string-divisibility.english.md @@ -39,7 +39,9 @@ tests: - text: substringDivisibility() should return an array. testString: assert(Array.isArray(substringDivisibility())); - text: substringDivisibility() should return [ 1430952867, 1460357289, 1406357289, 4130952867, 4160357289, 4106357289 ]. - testString: assert.deepEqual(substringDivisibility(), [ 1430952867, 1460357289, 1406357289, 4130952867, 4160357289, 4106357289 ]); + testString: assert.sameMembers(substringDivisibility(), [ 1430952867, 1460357289, 1406357289, 4130952867, 4160357289, 4106357289 ]); + - text: You should not copy and return the array. + testString: assert(!removeJSComments(code).match(/(1430952867)|(1460357289)|(1406357289)|(4130952867)|(4160357289)|(4106357289)/)) ``` @@ -61,7 +63,14 @@ substringDivisibility(); +### After Test +
+```js +const removeJSComments = str => str.replace(/\/\*[\s\S]*?\*\/|\/\/.*$/gm, ''); +``` + +