From 9bf3fdbf382d04b958127299ccdb8e568321b4d6 Mon Sep 17 00:00:00 2001 From: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Date: Wed, 20 Nov 2019 06:45:19 -0800 Subject: [PATCH] fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860) * fix: changed challenge test text to use should * fix: changed have to be used in Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: reworded test verbiage Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: improved test verbiage Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: improved test verbiage Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: corrected typo Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: corrected typo Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: changed have the to be used in Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * fix: corrected verbiage Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com> --- ...ing-by-using-descriptive-link-text.english.md | 6 +++--- ...dio-content-with-the-audio-element.english.md | 2 +- ...essibility-with-the-figure-element.english.md | 2 +- ...on-easier-with-the-header-landmark.english.md | 2 +- ...ation-easier-with-the-nav-landmark.english.md | 2 +- ...t-element-for-better-accessibility.english.md | 2 +- ...y-to-change-the-size-of-an-element.english.md | 2 +- ...se-the-s-tag-to-strikethrough-text.english.md | 2 +- .../add-borders-around-your-elements.english.md | 4 ++-- ...a-fallback-value-to-a-css-variable.english.md | 4 ++-- ...-background-color-to-a-div-element.english.md | 4 ++-- .../basic-css/import-a-google-font.english.md | 4 ++-- .../basic-css/inherit-css-variables.english.md | 2 +- ...herit-styles-from-the-body-element.english.md | 8 ++++---- ...rcular-images-with-a-border-radius.english.md | 2 +- ...larations-by-styling-id-attributes.english.md | 6 +++--- ...ss-declarations-with-inline-styles.english.md | 2 +- .../set-the-id-of-an-element.english.md | 2 +- .../style-the-html-body-element.english.md | 6 +++--- ...se-a-css-class-to-style-an-element.english.md | 2 +- .../use-a-custom-css-variable.english.md | 8 ++++---- .../use-abbreviated-hex-code.english.md | 16 ++++++++-------- ...n-id-attribute-to-style-an-element.english.md | 6 +++--- ...se-css-selectors-to-style-elements.english.md | 8 ++++---- .../use-hex-code-for-specific-colors.english.md | 4 ++-- .../use-hex-code-to-mix-colors.english.md | 16 ++++++++-------- .../basic-css/use-rgb-to-mix-colors.english.md | 16 ++++++++-------- .../use-rgb-values-to-color-elements.english.md | 2 +- .../add-a-submit-button-to-a-form.english.md | 2 +- .../add-images-to-your-website.english.md | 2 +- ...d-placeholder-text-to-a-text-field.english.md | 4 ++-- .../comment-out-html.english.md | 10 +++++----- .../create-a-bulleted-unordered-list.english.md | 6 +++--- .../create-a-form-element.english.md | 6 +++--- .../create-a-set-of-checkboxes.english.md | 2 +- .../create-a-set-of-radio-buttons.english.md | 4 ++-- .../create-an-ordered-list.english.md | 6 +++--- .../delete-html-elements.english.md | 6 +++--- .../headline-with-the-h2-element.english.md | 4 ++-- .../inform-with-the-paragraph-element.english.md | 2 +- .../introduction-to-html5-elements.english.md | 4 ++-- ...xternal-pages-with-anchor-elements.english.md | 2 +- ...-anchor-element-within-a-paragraph.english.md | 8 ++++---- ...ements-within-a-single-div-element.english.md | 8 ++++---- .../turn-an-image-into-a-link.english.md | 4 ++-- .../uncomment-html.english.md | 8 ++++---- .../create-a-media-query.english.md | 2 +- 47 files changed, 116 insertions(+), 116 deletions(-) diff --git a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/give-links-meaning-by-using-descriptive-link-text.english.md b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/give-links-meaning-by-using-descriptive-link-text.english.md index 9c346c9357..3ba07dcb6d 100644 --- a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/give-links-meaning-by-using-descriptive-link-text.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/give-links-meaning-by-using-descriptive-link-text.english.md @@ -24,10 +24,10 @@ The link text that Camper Cat is using is not very descriptive without the surro tests: - text: Your code should move the anchor a tags from around the words "Click here" to wrap around the words "information about batteries". testString: assert($('a').text().match(/^(information about batteries)$/g)); - - text: Your a element should have an href attribute with a value of an empty string "". + - text: The a element should have an href attribute with a value of an empty string "". testString: assert($('a').attr('href') === ''); - - text: Your a element should have a closing tag. - testString: assert($('a').length === code.match(/<\/a>/g).length); + - text: The a element should have a closing tag. + testString: assert(code.match(/<\/a>/g) && code.match(/<\/a>/g).length === code.match(//g).length); ``` diff --git a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-accessibility-of-audio-content-with-the-audio-element.english.md b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-accessibility-of-audio-content-with-the-audio-element.english.md index c53114a129..fce22783b8 100644 --- a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-accessibility-of-audio-content-with-the-audio-element.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-accessibility-of-audio-content-with-the-audio-element.english.md @@ -35,7 +35,7 @@ Time to take a break from Camper Cat and meet fellow camper Zersiax (@zersiax), tests: - text: Your code should have one audio tag. testString: assert($('audio').length === 1); - - text: Make sure your audio element has a closing tag. + - text: Your audio element should have a closing tag. testString: assert(code.match(/<\/audio>/g).length === 1 && code.match(/[\s\S]*<\/audio>/g)); - text: The audio tag should have the controls attribute. testString: assert($('audio').attr('controls')); diff --git a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-chart-accessibility-with-the-figure-element.english.md b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-chart-accessibility-with-the-figure-element.english.md index 00c810f7a6..9ca4ffc351 100644 --- a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-chart-accessibility-with-the-figure-element.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/improve-chart-accessibility-with-the-figure-element.english.md @@ -44,7 +44,7 @@ tests: testString: assert($('p').length == 0); - text: The figcaption should be a child of the figure tag. testString: assert($('figure').children('figcaption').length == 1); - - text: Make sure your figure element has a closing tag. + - text: Your figure element should have a closing tag. testString: assert(code.match(/<\/figure>/g) && code.match(/<\/figure>/g).length === code.match(/
/g).length); ``` diff --git a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-header-landmark.english.md b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-header-landmark.english.md index 55a964b011..18bc8de59d 100644 --- a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-header-landmark.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-header-landmark.english.md @@ -29,7 +29,7 @@ tests: testString: assert($('header').children('h1').length == 1); - text: Your code should not have any div tags. testString: assert($('div').length == 0); - - text: Make sure your header element has a closing tag. + - text: Your header element should have a closing tag. testString: assert(code.match(/<\/header>/g) && code.match(/<\/header>/g).length === code.match(/
/g).length); ``` diff --git a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-nav-landmark.english.md b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-nav-landmark.english.md index 3010713fd9..d99b3a1629 100644 --- a/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-nav-landmark.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-screen-reader-navigation-easier-with-the-nav-landmark.english.md @@ -28,7 +28,7 @@ tests: testString: assert($('nav').children('ul').length == 1); - text: Your code should not have any div tags. testString: assert($('div').length == 0); - - text: Make sure your nav element has a closing tag. + - text: Your nav element should have a closing tag. testString: assert(code.match(/<\/nav>/g) && code.match(/<\/nav>/g).length === code.match(/