gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: valid username lowercase (#42172)

Browse Source 
* fix: valid username lowercase

* test: add test in the validate for reject uppercase characters

* test: add test in the cypress for check on uppercase characters and reject it.
This commit is contained in:
Lance
2021-05-20 02:04:00 -05:00
committed by GitHub
parent 938e5913fa
commit 9c86168b2f
5 changed files with 35 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
utils/validate.test.js
View File

@ -5,7 +5,8 @@ const {
usernameTooShort,
validationSuccess,
usernameIsHttpStatusCode,
invalidCharError
invalidCharError,
usernameUpperCase
} = require('./validate');
function inRange(num, range) {
@ -38,6 +39,9 @@ describe('isValidUsername', () => {
expect(isValidUsername('a-b')).toStrictEqual(validationSuccess);
expect(isValidUsername('a_b')).toStrictEqual(validationSuccess);
});
it('rejects uppercase characters', () => {
expect(isValidUsername('Quincy')).toStrictEqual(usernameUpperCase);
});
it('rejects all other ASCII characters', () => {
const allowedCharactersList = ['-', '_', '+'];
@ -52,7 +56,7 @@ describe('isValidUsername', () => {
let expected = invalidCharError;
if (allowedCharactersList.includes(char)) expected = validationSuccess;
if (inRange(code, numbers)) expected = validationSuccess;
if (inRange(code, upperCase)) expected = validationSuccess;
if (inRange(code, upperCase)) expected = usernameUpperCase;
if (inRange(code, lowerCase)) expected = validationSuccess;
expect(isValidUsername(base + char)).toStrictEqual(expected);
}