From 9cf283aab950fb58e75e95c04ae0b7f80d6387f9 Mon Sep 17 00:00:00 2001 From: Lewis Horwood Date: Sat, 23 Feb 2019 03:46:06 +0900 Subject: [PATCH] Add tests reflecting #19390 (#19477) * Add test reflecting #19390 Added two tests to prevent checking only `Alan`. * Split into 4 tests for each prop Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace --- ...eck-if-an-object-has-a-property.english.md | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/check-if-an-object-has-a-property.english.md b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/check-if-an-object-has-a-property.english.md index a914c44c06..8deb17c569 100644 --- a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/check-if-an-object-has-a-property.english.md +++ b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/check-if-an-object-has-a-property.english.md @@ -20,13 +20,18 @@ We've created an object, users, with some users in it and a functio ```yml tests: - - text: The users object only contains the keys Alan, Jeff, Sarah, and Ryan - testString: assert('Alan' in users && 'Jeff' in users && 'Sarah' in users && 'Ryan' in users && Object.keys(users).length === 4, 'The users object only contains the keys Alan, Jeff, Sarah, and Ryan'); - - text: The function isEveryoneHere returns true if Alan, Jeff, Sarah, and Ryan are properties on the users object - testString: assert(isEveryoneHere(users) === true, 'The function isEveryoneHere returns true if Alan, Jeff, Sarah, and Ryan are properties on the users object'); - - text: The function isEveryoneHere returns false if Alan, Jeff, Sarah, and Ryan are not properties on the users object - testString: assert((function() { delete users.Alan; delete users.Jeff; delete users.Sarah; delete users.Ryan; return isEveryoneHere(users) })() === false, 'The function isEveryoneHere returns false if Alan, Jeff, Sarah, and Ryan are not properties on the users object'); - + - text: 'The users object only contains the keys Alan, Jeff, Sarah, and Ryan' + testString: 'assert("Alan" in users && "Jeff" in users && "Sarah" in users && "Ryan" in users && Object.keys(users).length === 4, "The users object only contains the keys Alan, Jeff, Sarah, and Ryan");' + - text: 'The function isEveryoneHere returns true if Alan, Jeff, Sarah, and Ryan are properties on the users object' + testString: 'assert(isEveryoneHere(users) === true, "The function isEveryoneHere returns true if Alan, Jeff, Sarah, and Ryan are properties on the users object");' + - text: 'The function isEveryoneHere returns false if Alan is not a property on the users object' + testString: 'assert((function() { delete users.Alan; return isEveryoneHere(users) })() === false, "The function isEveryoneHere returns false if Alan is not a property on the users object");' + - text: 'The function isEveryoneHere returns false if Jeff is not a property on the users object' + testString: 'assert((function() { delete users.Jeff; return isEveryoneHere(users) })() === false, "The function isEveryoneHere returns false if Jeff is not a property on the users object");' + - text: 'The function isEveryoneHere returns false if Sarah is not a property on the users object' + testString: 'assert((function() { delete users.Sarah; return isEveryoneHere(users) })() === false, "The function isEveryoneHere returns false if Sarah is not a property on the users object");' + - text: 'The function isEveryoneHere returns false if Ryan is not a property on the users object' + testString: 'assert((function() { delete users.Ryan; return isEveryoneHere(users) })() === false, "The function isEveryoneHere returns false if Ryan is not a property on the users object");' ```