From 9db88a0d7c1bce32e754f7522abf8f7dfd54147a Mon Sep 17 00:00:00 2001 From: Ahmad Shahzad <56808339+turnonsync@users.noreply.github.com> Date: Sun, 27 Oct 2019 01:55:10 +0500 Subject: [PATCH] Fixed a typo in Specify How Fonts Degrade lesson. (#37567) * Fixed a typo in Specify How Fonts Degrade. '-->!' inside the code is misleading and prompts a learner to put the exclamation mark when it is not needed as '-->!' is also followed by a period. Instead of "'-->!'.", it should be "'-->'." * Made text wording consistent for the test instructions. * Changed "To begin with," to "To begin," and fixed a minor typo. If we are going to use "To begin with," the sentence should be "To begin with the lesson/challenge", otherwise, "To begin" will be more than enough. Also added a space between "font(using HTML..." and changed it to "font (using HTML...". --- .../basic-css/specify-how-fonts-should-degrade.english.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/curriculum/challenges/english/01-responsive-web-design/basic-css/specify-how-fonts-should-degrade.english.md b/curriculum/challenges/english/01-responsive-web-design/basic-css/specify-how-fonts-should-degrade.english.md index 6f0608624b..cdccb0117b 100644 --- a/curriculum/challenges/english/01-responsive-web-design/basic-css/specify-how-fonts-should-degrade.english.md +++ b/curriculum/challenges/english/01-responsive-web-design/basic-css/specify-how-fonts-should-degrade.english.md @@ -23,8 +23,8 @@ Generic font family names are not case-sensitive. Also, they do not need quotes ## Instructions
-To begin with, apply the monospace font to the h2 element, so that it now has two fonts - Lobster and monospace. -In the last challenge, you imported the Lobster font using the link tag. Now comment out that import of the Lobster font(using the HTML comments you learned before) from Google Fonts so that it isn't available anymore. Notice how your h2 element degrades to the monospace font. +To begin, apply the monospace font to the h2 element, so that it now has two fonts - Lobster and monospace. +In the last challenge, you imported the Lobster font using the link tag. Now comment out that import of the Lobster font (using the HTML comments you learned before) from Google Fonts so that it isn't available anymore. Notice how your h2 element degrades to the monospace font. Note: If you have the Lobster font installed on your computer, you won't see the degradation because your browser is able to find the font.
@@ -37,9 +37,9 @@ tests: testString: assert($("h2").css("font-family").match(/^"?lobster/i)); - text: Your h2 element should degrade to the font monospace when Lobster is not available. testString: assert(/\s*h2\s*\{\s*font-family\:\s*(\'|")?Lobster(\'|")?,\s*monospace\s*;\s*\}/gi.test(code)); - - text: Comment out your call to Google for the Lobster font by putting <!-- in front of it. + - text: You should comment out your call to Google for the Lobster font by putting <!-- in front of it. testString: assert(new RegExp("", "gi").test(code)); ```