gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)

Browse Source 
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
This commit is contained in:
Randell Dawson
2019-02-24 23:07:11 -08:00
committed by Manish Giri
parent 5d3ea76a3e
commit 9e07f99b9e
1 changed files with 44 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
curriculum/challenges/english/01-responsive-web-design/basic-css/use-clockwise-notation-to-specify-the-margin-of-an-element.english.md
View File

@ -24,13 +24,15 @@ Use <code>Clockwise Notation</code> to give the element with the <code>blue-box<
```yml ```yml
tests: tests:
- text: Your <code>blue-box</code> class should give the top of elements <code>40px</code> of <code>margin</code>. - text: Your <code>blue-box</code> class should give the top of elements <code>40px</code> of <code>margin</code>.
testString: assert($(".blue-box").css("margin-top") === "40px", 'Your <code>blue-box</code> class should give the top of elements <code>40px</code> of <code>margin</code>.'); testString: assert($(".blue-box").css("margin-top") === "40px");
- text: Your <code>blue-box</code> class should give the right of elements <code>20px</code> of <code>margin</code>. - text: Your <code>blue-box</code> class should give the right of elements <code>20px</code> of <code>margin</code>.
testString: assert($(".blue-box").css("margin-right") === "20px", 'Your <code>blue-box</code> class should give the right of elements <code>20px</code> of <code>margin</code>.'); testString: assert($(".blue-box").css("margin-right") === "20px");
- text: Your <code>blue-box</code> class should give the bottom of elements <code>20px</code> of <code>margin</code>. - text: Your <code>blue-box</code> class should give the bottom of elements <code>20px</code> of <code>margin</code>.
testString: assert($(".blue-box").css("margin-bottom") === "20px", 'Your <code>blue-box</code> class should give the bottom of elements <code>20px</code> of <code>margin</code>.'); testString: assert($(".blue-box").css("margin-bottom") === "20px");
- text: Your <code>blue-box</code> class should give the left of elements <code>40px</code> of <code>margin</code>. - text: Your <code>blue-box</code> class should give the left of elements <code>40px</code> of <code>margin</code>.
testString: assert($(".blue-box").css("margin-left") === "40px", 'Your <code>blue-box</code> class should give the left of elements <code>40px</code> of <code>margin</code>.'); testString: assert($(".blue-box").css("margin-left") === "40px");
- text: You should use the clockwise notation to set the margin of <code>blue-box</code> class.
testString: const removeCssComments = str => str.replace(/\/\*[\s\S]+?\*\//g, '');assert(/\.blue-box\s*{[\s\S]*margin:\s*\d+px\s+\d+px\s+\d+px\s+\d+px(;[\s\S]*}|\s*)/.test(removeCssComments($('style').text())));
``` ```
@ -81,14 +83,48 @@ tests:
</div> </div>
</section> </section>
## Solution ## Solution
<section id='solution'> <section id='solution'>
```js ```html
// solution required <style>
.injected-text {
margin-bottom: -25px;
text-align: center;
}
.box {
border-style: solid;
border-color: black;
border-width: 5px;
text-align: center;
}
.yellow-box {
background-color: yellow;
padding: 20px 40px 20px 40px;
}
.red-box {
background-color: crimson;
color: #fff;
margin: 20px 40px 20px 40px;
}
.blue-box {
background-color: blue;
color: #fff;
margin: 40px 20px 20px 40px;
}
</style>
<h5 class="injected-text">margin</h5>
<div class="box yellow-box">
<h5 class="box red-box">padding</h5>
<h5 class="box blue-box">padding</h5>
</div>
``` ```
</section> </section>