gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

don't throw err on mongo errors but send 500 and call next

Browse Source
This commit is contained in:
Nathan Leniz
2015-03-10 08:15:43 +09:00
parent ac89c44064
commit a65216e29e
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
controllers/story.js
View File

@ -28,7 +28,8 @@ exports.hotJSON = function(req, res) {
var story = Story.find({}).sort({'timePosted': -1}).limit(1000); var story = Story.find({}).sort({'timePosted': -1}).limit(1000);
story.exec(function(err, stories) { story.exec(function(err, stories) {
if (err) { if (err) {
throw err; res.send(500);
return next(err);
} }
var foundationDate = 1413298800000; var foundationDate = 1413298800000;
@ -47,7 +48,8 @@ exports.recentJSON = function(req, res) {
var story = Story.find({}).sort({'timePosted': -1}).limit(100); var story = Story.find({}).sort({'timePosted': -1}).limit(100);
story.exec(function(err, stories) { story.exec(function(err, stories) {
if (err) { if (err) {
throw err; res.status(500);
return next(err);
} }
res.json(stories); res.json(stories);
}); });
@ -184,11 +186,12 @@ exports.getStories = function(req, res) {
}); });
}; };
exports.upvote = function(req, res) { exports.upvote = function(req, res, next) {
var data = req.body.data; var data = req.body.data;
Story.find({'_id': data.id}, function(err, story) { Story.find({'_id': data.id}, function(err, story) {
if (err) { if (err) {
throw err; res.status(500);
return next(err);
} }
story = story.pop(); story = story.pop();
story.rank++; story.rank++;
@ -204,11 +207,12 @@ exports.upvote = function(req, res) {
}); });
}; };
exports.comments = function(req, res) { exports.comments = function(req, res, next) {
var data = req.params.id; var data = req.params.id;
Comment.find({'_id': data}, function(err, comment) { Comment.find({'_id': data}, function(err, comment) {
if (err) { if (err) {
throw err; res.status(500);
return next(err);
} }
comment = comment.pop(); comment = comment.pop();
return res.send(comment); return res.send(comment);