gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Correct seed code errors (#32355)

Browse Source 
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
This commit is contained in:
BurnhamG
2019-02-14 16:24:38 -05:00
committed by Randell Dawson
parent fadfbca63c
commit a825708e3e
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/refactor-global-variables-out-of-functions.english.md
View File

@ -14,7 +14,7 @@ Adding one to a number is not very exciting, but we can apply these principles w
## Instructions ## Instructions
<section id='instructions'> <section id='instructions'>
Rewrite the code so the global array <code>bookList</code> is not changed inside either function. The <code>add</code> function should add the given <code>bookName</code> to the end of an array. The <code>remove</code> function should remove the given <code>bookName</code> from an array. Both functions should return an array, and any new parameters should be added before the <code>bookName</code> one. Rewrite the code so the global array <code>bookList</code> is not changed inside either function. The <code>add</code> function should add the given <code>bookName</code> to the end of an array. The <code>remove</code> function should remove the given <code>bookName</code> from an array. Both functions should return an array, and any new parameters should be added before the <code>bookName</code> parameter.
</section> </section>
## Tests ## Tests
@ -45,13 +45,14 @@ tests:
var bookList = ["The Hound of the Baskervilles", "On The Electrodynamics of Moving Bodies", "Philosophiæ Naturalis Principia Mathematica", "Disquisitiones Arithmeticae"]; var bookList = ["The Hound of the Baskervilles", "On The Electrodynamics of Moving Bodies", "Philosophiæ Naturalis Principia Mathematica", "Disquisitiones Arithmeticae"];
/* This function should add a book to the list and return the list */ /* This function should add a book to the list and return the list */
// New parameters should come before the bookName one // New parameters should come before bookName
// Add your code below this line // Add your code below this line
function add (bookName) { function add (bookName) {
return bookList.push(bookName); bookList.push(bookName);
return bookList;
// Add your code above this line // Add your code above this line
} }
@ -60,9 +61,11 @@ function add (bookName) {
// Add your code below this line // Add your code below this line
function remove (bookName) { function remove (bookName) {
if (bookList.indexOf(bookName) >= 0) { var book_index = bookList.indexOf(bookName);
if (book_index >= 0) {
return bookList.splice(0, 1, bookName); bookList.splice(book_index, 1);
return bookList;
// Add your code above this line // Add your code above this line
} }