From a8a7eeb10daf1eb49c01de94cae0d7db854ff4cc Mon Sep 17 00:00:00 2001 From: Tom <20648924+moT01@users.noreply.github.com> Date: Fri, 20 Dec 2019 08:00:33 -0600 Subject: [PATCH] fix: make github url optional for backend projects (#37936) --- api-server/server/boot/challenge.js | 6 +----- client/src/templates/Challenges/projects/ProjectForm.js | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/api-server/server/boot/challenge.js b/api-server/server/boot/challenge.js index dc259f1f88..3c12293a43 100644 --- a/api-server/server/boot/challenge.js +++ b/api-server/server/boot/challenge.js @@ -261,11 +261,7 @@ function projectCompleted(req, res, next) { ]); completedChallenge.completedDate = Date.now(); - if ( - !completedChallenge.solution || - // only basejumps require github links - (completedChallenge.challengeType === 4 && !completedChallenge.githubLink) - ) { + if (!completedChallenge.solution) { return res.status(403).json({ type: 'error', message: diff --git a/client/src/templates/Challenges/projects/ProjectForm.js b/client/src/templates/Challenges/projects/ProjectForm.js index a743459b9e..d2323d8d5b 100644 --- a/client/src/templates/Challenges/projects/ProjectForm.js +++ b/client/src/templates/Challenges/projects/ProjectForm.js @@ -18,7 +18,7 @@ const options = { solution: 'url', githubLink: 'url' }, - required: ['solution', 'githubLink'] + required: ['solution'] }; export class ProjectForm extends Component {