gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat: show one hint at a time

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2020-07-14 17:09:36 +02:00
committed by Mrugesh Mohapatra
parent 68b223322f
commit ad83a2e3f4
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
client/src/templates/Challenges/classic/Editor.js
View File

@ -35,7 +35,7 @@ const propTypes = {
inAccessibilityMode: PropTypes.bool.isRequired, inAccessibilityMode: PropTypes.bool.isRequired,
initialEditorContent: PropTypes.string, initialEditorContent: PropTypes.string,
initialExt: PropTypes.string, initialExt: PropTypes.string,
output: PropTypes.string, output: PropTypes.arrayOf(PropTypes.string),
saveEditorContent: PropTypes.func.isRequired, saveEditorContent: PropTypes.func.isRequired,
setAccessibilityMode: PropTypes.func.isRequired, setAccessibilityMode: PropTypes.func.isRequired,
setEditorFocusability: PropTypes.func, setEditorFocusability: PropTypes.func,
@ -478,8 +478,13 @@ class Editor extends Component {
createOutputNode() { createOutputNode() {
if (this._outputNode) return this._outputNode; if (this._outputNode) return this._outputNode;
const outputNode = document.createElement('div'); const outputNode = document.createElement('div');
const statusNode = document.createElement('div');
outputNode.innerHTML = 'TESTS GO HERE'; const hintNode = document.createElement('div');
outputNode.appendChild(statusNode);
outputNode.appendChild(hintNode);
hintNode.setAttribute('id', 'test-output');
statusNode.setAttribute('id', 'test-status');
statusNode.innerHTML = '// tests';
// TODO: does it? // TODO: does it?
// The z-index needs increasing as ViewZones default to below the lines. // The z-index needs increasing as ViewZones default to below the lines.
@ -910,14 +915,23 @@ class Editor extends Component {
} }
if (this._editor) { if (this._editor) {
const { output } = this.props;
if (this.props.output !== prevProps.output && this._outputNode) { if (this.props.output !== prevProps.output && this._outputNode) {
// TODO: output gets wiped when the preview gets updated, keeping the // TODO: output gets wiped when the preview gets updated, keeping the
// display is an anti-pattern (the render should not ignore props!). // display is an anti-pattern (the render should not ignore props!).
// The correct solution is probably to create a new redux variable // The correct solution is probably to create a new redux variable
// (shownHint,maybe) and have that persist through previews. But, for // (shownHint,maybe) and have that persist through previews. But, for
// now: // now:
if (this.props.output) { if (output) {
this._outputNode.innerHTML = this.props.output; console.log('OUTPUT', output);
if (output[0]) {
document.getElementById('test-status').innerHTML = output[0];
}
if (output[1]) {
document.getElementById('test-output').innerHTML = output[1];
}
if (this.data[fileKey].startEditDecId) { if (this.data[fileKey].startEditDecId) {
this.updateOutputZone(); this.updateOutputZone();
} }