From b0bfc00f21888c6fc67033034ef87bf886459679 Mon Sep 17 00:00:00 2001 From: Mrugesh Mohapatra Date: Thu, 11 Mar 2021 01:26:07 +0530 Subject: [PATCH] fix(actions): update workflow matrices & docs This commit intentionally adds a matrix to keep supporting Node.js 12 while we evaluate it --- .github/workflows/cypress.yml | 5 +++-- .github/workflows/lighthouse-ci.yml | 4 ++-- .github/workflows/node.js-tests-upcoming.yml | 6 +++--- .github/workflows/node.js-tests.yml | 8 ++++---- docs/how-to-setup-freecodecamp-locally.md | 2 +- 5 files changed, 13 insertions(+), 12 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 44d2c72829..734223d6b6 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -8,6 +8,7 @@ jobs: strategy: matrix: browsers: [chrome, firefox] + node-version: [14.x, 12.x] services: mongodb: image: mongo:3.6.19 @@ -15,7 +16,7 @@ jobs: - 27017:27017 steps: - # We use .npmrc to set the default version to 0, and prevents download during developement. + # We use .npmrc to set the default version to 0, and prevents download during development. # This installs it specifically in the CI runs. - name: Set Action Environment Variables run: | @@ -27,7 +28,7 @@ jobs: uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} diff --git a/.github/workflows/lighthouse-ci.yml b/.github/workflows/lighthouse-ci.yml index 124716b47d..ba9d8b3dc6 100644 --- a/.github/workflows/lighthouse-ci.yml +++ b/.github/workflows/lighthouse-ci.yml @@ -21,14 +21,14 @@ jobs: strategy: matrix: - node-version: [12.x] + node-version: [14.x, 12.x] steps: - name: Checkout Source Files uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} diff --git a/.github/workflows/node.js-tests-upcoming.yml b/.github/workflows/node.js-tests-upcoming.yml index aa2e60d41e..72dc979ca2 100644 --- a/.github/workflows/node.js-tests-upcoming.yml +++ b/.github/workflows/node.js-tests-upcoming.yml @@ -17,14 +17,14 @@ jobs: strategy: matrix: - node-version: [12.x] + node-version: [14.x, 12.x] steps: - name: Checkout Source Files uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} @@ -68,7 +68,7 @@ jobs: uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} diff --git a/.github/workflows/node.js-tests.yml b/.github/workflows/node.js-tests.yml index d7f6ace7d4..5a0da35da0 100644 --- a/.github/workflows/node.js-tests.yml +++ b/.github/workflows/node.js-tests.yml @@ -8,14 +8,14 @@ jobs: strategy: matrix: - node-version: [12.x] + node-version: [14.x, 12.x] steps: - name: Checkout Source Files uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} @@ -49,14 +49,14 @@ jobs: strategy: matrix: - node-version: [12.x] + node-version: [14.x, 12.x] steps: - name: Checkout Source Files uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} diff --git a/docs/how-to-setup-freecodecamp-locally.md b/docs/how-to-setup-freecodecamp-locally.md index 1fda055692..585384c964 100644 --- a/docs/how-to-setup-freecodecamp-locally.md +++ b/docs/how-to-setup-freecodecamp-locally.md @@ -23,7 +23,7 @@ Some community members also develop on Windows 10 natively with Git for Windows | Prerequisite | Version | Notes | | ----------------------------- | ------- | -------------------------------------------------------------------- | -| [Node.js](http://nodejs.org) | `12.x` | [LTS Schedule](https://github.com/nodejs/Release#release-schedule) | +| [Node.js](http://nodejs.org) | `14.x` | [LTS Schedule](https://github.com/nodejs/Release#release-schedule) | | npm (comes bundled with Node) | `6.x` | Does not have LTS releases, we use the version bundled with Node LTS | | [MongoDB Community Server](https://docs.mongodb.com/manual/administration/install-community/) | `3.6` | [Release Notes](https://docs.mongodb.com/manual/release-notes/), Note: We are currently on `3.6`, an [upgrade is planned](https://github.com/freeCodeCamp/freeCodeCamp/issues/18275). |