From b0e3d7369b669b7c91caf3dfc644fb2da5df0cbe Mon Sep 17 00:00:00 2001 From: Oliver Eyton-Williams Date: Mon, 2 Nov 2020 18:22:01 +0100 Subject: [PATCH] fix(learn): reload when challenge tests change (#39832) --- client/src/templates/Challenges/classic/Show.js | 12 +++++++++--- .../templates/Challenges/projects/backend/Show.js | 14 ++++++++++---- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/client/src/templates/Challenges/classic/Show.js b/client/src/templates/Challenges/classic/Show.js index eb7981491c..c830c1cec0 100644 --- a/client/src/templates/Challenges/classic/Show.js +++ b/client/src/templates/Challenges/classic/Show.js @@ -129,15 +129,21 @@ class ShowClassic extends Component { componentDidUpdate(prevProps) { const { data: { - challengeNode: { title: prevTitle } + challengeNode: { + title: prevTitle, + fields: { tests: prevTests } + } } } = prevProps; const { data: { - challengeNode: { title: currentTitle } + challengeNode: { + title: currentTitle, + fields: { tests: currTests } + } } } = this.props; - if (prevTitle !== currentTitle) { + if (prevTitle !== currentTitle || prevTests !== currTests) { this.initializeComponent(currentTitle); } } diff --git a/client/src/templates/Challenges/projects/backend/Show.js b/client/src/templates/Challenges/projects/backend/Show.js index 63f826af5a..92d4a0e0f9 100644 --- a/client/src/templates/Challenges/projects/backend/Show.js +++ b/client/src/templates/Challenges/projects/backend/Show.js @@ -100,16 +100,22 @@ export class BackEnd extends Component { componentDidUpdate(prevProps) { const { data: { - challengeNode: { title: prevTitle } + challengeNode: { + title: prevTitle, + fields: { tests: prevTests } + } } } = prevProps; const { data: { - challengeNode: { title: currentTitle } + challengeNode: { + title: currentTitle, + fields: { tests: currTests } + } } } = this.props; - if (prevTitle !== currentTitle) { - this.initializeComponent(); + if (prevTitle !== currentTitle || prevTests !== currTests) { + this.initializeComponent(currentTitle); } }