From b2276fe8072b62d0bde16d37590829d1ce7ed6ec Mon Sep 17 00:00:00 2001 From: Stuart Taylor Date: Fri, 1 Jun 2018 18:07:28 +0100 Subject: [PATCH] fix(errors): Filter out handled errors from rollbar (#17368) Give me my inbox back!! --- server/middlewares/error-reporter.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/server/middlewares/error-reporter.js b/server/middlewares/error-reporter.js index b6cabca8b0..196b2dbe5d 100644 --- a/server/middlewares/error-reporter.js +++ b/server/middlewares/error-reporter.js @@ -34,8 +34,16 @@ export default function errrorReporter() { }; } return (err, req, res, next) => { + // handled errors do not need to be reported, + // they report a message and maybe redirect the user + // errors with status codes shouldn't be reported + // as they are usually user messages + if (isHandledError(err) || err.statusCode || err.status) { + return next(err); + } + // logging the error provides us with more information, + // i.e isAuthenticatedUser, req.route console.error(errTemplate(err, req)); - rollbar.error(err.message, err); - next(err); + return rollbar.error(err.message, err); }; }