From b228d426f64c5855093cd15db2cfa4c6e546afb2 Mon Sep 17 00:00:00 2001
From: Honman Yau <honmanyau@users.noreply.github.com>
Date: Sat, 1 Dec 2018 18:48:25 +1100
Subject: [PATCH] Merge pull request #16 from
 RandellDawson/feat/create-search-component

[Feature] Finalized Search Component functionality
---
 .../app/app/src/components/FilenameResults.js | 42 +++++++++++
 .../app/app/src/components/Input.js           |  1 -
 .../app/app/src/components/Pareto.js          | 34 ++++++---
 .../components/{Results.js => PrResults.js}   | 21 +++---
 .../app/app/src/components/Search.js          | 70 +++++++++++++------
 .../app/app/src/components/SearchOption.js    | 16 +++++
 dashboard-client/app/app/src/index.css        |  5 ++
 dashboard-client/app/yarn.lock                |  4 ++
 8 files changed, 154 insertions(+), 39 deletions(-)
 create mode 100644 dashboard-client/app/app/src/components/FilenameResults.js
 rename dashboard-client/app/app/src/components/{Results.js => PrResults.js} (62%)
 create mode 100644 dashboard-client/app/app/src/components/SearchOption.js
 create mode 100644 dashboard-client/app/yarn.lock

diff --git a/dashboard-client/app/app/src/components/FilenameResults.js b/dashboard-client/app/app/src/components/FilenameResults.js
new file mode 100644
index 0000000000..ec9446e784
--- /dev/null
+++ b/dashboard-client/app/app/src/components/FilenameResults.js
@@ -0,0 +1,42 @@
+import React from 'react';
+import styled from 'styled-components';
+
+const List = styled.div`
+  margin: 5px;
+  display: flex;
+  flex-wrap: wrap;
+`;
+
+const ListItem = styled.div`
+  padding: 0 5px;
+`;
+
+const FilenameResults = ({ searchValue, results }) => {
+  const elements = results.map((result) => {
+    const { filename, prs: prObjects } = result;
+    const prs = prObjects.map(({ number }, index) => {
+      const prUrl = `https://github.com/freeCodeCamp/freeCodeCamp/pull/${number}`;
+      return <ListItem key={`${filename}-${index}`}>
+        • <a href={prUrl} rel="noopener noreferrer" target="_blank">{number}</a>
+      </ListItem>;
+    });
+
+    return (
+      <div key={filename}>
+        {filename}
+        <List>
+          {prs}
+        </List>
+      </div>
+    );
+  });
+
+  return (
+    <div>
+      {results.length ? <h3>Results for: {searchValue}</h3> : null}
+      {elements}
+    </div>
+  );
+};
+
+export default FilenameResults;
diff --git a/dashboard-client/app/app/src/components/Input.js b/dashboard-client/app/app/src/components/Input.js
index ae1b45cbfa..da8ae2ecb7 100644
--- a/dashboard-client/app/app/src/components/Input.js
+++ b/dashboard-client/app/app/src/components/Input.js
@@ -8,7 +8,6 @@ const Container = styled.input`
 const Input = React.forwardRef((props, ref) => (
   <Container
     type="text"
-    placeholder="PR #"
     onChange={props.onInputEvent}
     onKeyPress={props.onInputEvent}
     value={props.value}
diff --git a/dashboard-client/app/app/src/components/Pareto.js b/dashboard-client/app/app/src/components/Pareto.js
index 1364bc45ca..c6a3aca8b8 100644
--- a/dashboard-client/app/app/src/components/Pareto.js
+++ b/dashboard-client/app/app/src/components/Pareto.js
@@ -7,8 +7,24 @@ const Result = styled.div`
   &:nth-child(odd) {
     background: #eee;
   }
+  padding: 3px;
 `;
 
+const List = styled.div`
+  margin: 5px;
+  display: flex;
+  flex-wrap: wrap;
+`;
+
+const ListItem = styled.a`
+  flex-basis: 33%;
+  overflow: hidden;
+`;
+
+const detailsStyle = { padding: '3px' };
+
+const filenameTitle = { fontWeight: '600' };
+
 class Pareto extends React.Component {
   state = {
     data: []
@@ -33,20 +49,22 @@ class Pareto extends React.Component {
 
   render() {
     const { data } = this.state;
-
     const elements = data.map((entry) => {
       const { filename, count, prs } = entry;
-      const prsList = prs.reduce((html, { number, username }) => {
+      const prsList = prs.map(({ number, username }) => {
         const prUrl = `https://github.com/freeCodeCamp/freeCodeCamp/pull/${number}`;
-        return html += `
-          <a href=${prUrl} rel="noopener noreferrer" target="_blank">#${number} <span>${username}</span></a>, `;
-      }, '');
+        return (
+          <ListItem href={prUrl} rel="noopener noreferrer" target="_blank">
+            #{number} <span>({username})</span>
+          </ListItem>
+        )
+      });
       return (
         <Result key={filename}>
-          {filename}<br />
-          <details>
+          <span style={filenameTitle}>{filename}</span><br />
+          <details style={detailsStyle}>
             <summary># of PRs: {count}</summary>
-            <div dangerouslySetInnerHTML={{__html: prsList}} />
+            <List>{prsList}</List>
           </details>
         </Result>
       );
diff --git a/dashboard-client/app/app/src/components/Results.js b/dashboard-client/app/app/src/components/PrResults.js
similarity index 62%
rename from dashboard-client/app/app/src/components/Results.js
rename to dashboard-client/app/app/src/components/PrResults.js
index 8ec3191703..4b3554d5d9 100644
--- a/dashboard-client/app/app/src/components/Results.js
+++ b/dashboard-client/app/app/src/components/PrResults.js
@@ -1,20 +1,24 @@
 import React from 'react';
 import styled from 'styled-components';
 
-const List = styled.ul`
-  margin: 5px;
+const Container = styled.div`
+  margin-bottom: 15px;
 `;
 
-const Results = ({ foundPRs }) => {
-  const elements = foundPRs.map((foundPR) => {
-    const { number, filenames, username } = foundPR;
+const List = styled.ul`
+  margin: 3px;
+`;
+
+const PrResults = ({ searchValue, results }) => {
+  const elements = results.map((result, idx) => {
+    const { number, filenames, username } = result;
     const files = filenames.map((filename, index) => {
       return <li key={`${number}-${index}`}>{filename}</li>;
     });
     const prUrl = `https://github.com/freeCodeCamp/freeCodeCamp/pull/${number}`
 
     return (
-      <div key={number}>
+      <Container key={`${number}-${idx}`}>
         {!Number(number)
           ? number
           : <>
@@ -25,15 +29,16 @@ const Results = ({ foundPRs }) => {
         <List>
           {files}
         </List>
-      </div>
+      </Container>
     );
   });
 
   return (
     <div>
+      {results.length ? <h3>Results for PR# {searchValue}</h3> : null}
       {elements}
     </div>
   );
 };
 
-export default Results;
+export default PrResults;
diff --git a/dashboard-client/app/app/src/components/Search.js b/dashboard-client/app/app/src/components/Search.js
index 6b4a8b54ed..604e71ddea 100644
--- a/dashboard-client/app/app/src/components/Search.js
+++ b/dashboard-client/app/app/src/components/Search.js
@@ -1,45 +1,62 @@
 import React, { Component } from 'react';
 
 import Input from './Input';
-import Results from './Results';
-
+import PrResults from './PrResults';
+import FilenameResults from './FilenameResults';
+import SearchOption from './SearchOption';
 class Search extends Component {
   state = {
-    number: '',
-    foundPRs: [],
+    searchValue: '',
+    selectedOption: 'pr',
+    results: []
   };
 
-  clearObj = { number: '', foundPRs: [] };
+  clearObj = { searchValue: '', results: [] };
 
   inputRef = React.createRef();
 
   handleInputEvent = (event) => {
-    const { type, key, target: { value } } = event;
+    const { type, key, target: { value: searchValue } } = event;
 
     if (type === 'change') {
-      if (Number(value) || value === '') {
-        this.setState((prevState) => ({ number: value, foundPRs: [] }));
+      if (this.state.selectedOption === 'pr'){
+        if (Number(searchValue) || searchValue === '') {
+          this.setState((prevState) => ({ searchValue, results: [] }));
+        }
+      }
+      else {
+        this.setState((prevState) => ({ searchValue, results: [] }));
       }
     }
     else if (type === 'keypress' && key === 'Enter') {
-      this.searchPRs(value);
+      this.searchPRs(searchValue);
     }
   }
 
   handleButtonClick = () => {
-    const { number } = this.state;
-    this.searchPRs(number);
+    const { searchValue } = this.state;
+    this.searchPRs(searchValue);
   }
 
-  searchPRs = (number) => {
-    fetch(`https://pr-relations.glitch.me/pr/${number}`)
+  handleOptionChange = (changeEvent) => {
+    const selectedOption = changeEvent.target.value;
+    this.setState((prevState) => ({ selectedOption, ...this.clearObj }));
+  }
+
+  searchPRs = (value) => {
+    const { selectedOption } = this.state;
+    const baseUrl = 'https://pr-relations.glitch.me/';
+    const fetchUrl = baseUrl + (selectedOption === 'pr' ? `pr/${value}` : `search/?value=${value}`);
+    fetch(fetchUrl)
     .then((response) => response.json())
-    .then(({ ok, foundPRs }) => {
-      if (ok) {
-        if (!foundPRs.length) {
-          foundPRs.push({ number: 'No PRs with matching files', filenames: [] });
+    .then((response) => {
+      if (response.ok) {
+        const { results }  = response;
+        const objArrName = selectedOption === 'pr' ? 'filenames' : 'prs';
+        if (!results.length) {
+          results.push({ searchValue: 'No matching results', [objArrName]: [] });
         }
-        this.setState((prevState) => ({ foundPRs }));
+        this.setState((prevState) => ({ results }));
       }
       else {
         this.inputRef.current.focus();
@@ -51,13 +68,22 @@ class Search extends Component {
   }
 
   render() {
-    const { handleButtonClick, handleInputEvent, inputRef, state } = this;
-    const { number, foundPRs } = state;
+    const { handleButtonClick, handleInputEvent, inputRef, handleOptionChange, state } = this;
+    const { searchValue, results, selectedOption } = state;
     return (
       <>
-        <Input ref={inputRef} value={number} onInputEvent={handleInputEvent} />
+        <div>
+          <SearchOption value="pr" onOptionChange={handleOptionChange} selectedOption={selectedOption}>
+            PR #
+          </SearchOption>
+          <SearchOption value="filename" onOptionChange={handleOptionChange} selectedOption={selectedOption}>
+            Filename
+          </SearchOption>
+        </div>
+        <Input ref={inputRef} value={searchValue} onInputEvent={handleInputEvent} />
         <button onClick={handleButtonClick}>Search</button>
-        <Results foundPRs={foundPRs} />
+        {selectedOption === 'pr' && <PrResults searchValue={searchValue} results={results} /> }
+        {selectedOption === 'filename' && <FilenameResults searchValue={searchValue} results={results} /> }
       </>
     );
   }
diff --git a/dashboard-client/app/app/src/components/SearchOption.js b/dashboard-client/app/app/src/components/SearchOption.js
new file mode 100644
index 0000000000..e527f7c211
--- /dev/null
+++ b/dashboard-client/app/app/src/components/SearchOption.js
@@ -0,0 +1,16 @@
+import React from 'react';
+
+const SearchOption = ({ children, value, selectedOption, onOptionChange }) => (
+  <label>
+    <input
+      name="searchType"
+      type="radio"
+      value={value}
+      checked={selectedOption === value}
+      onChange={onOptionChange}
+    />
+    {children}
+  </label>
+);
+
+export default SearchOption;
diff --git a/dashboard-client/app/app/src/index.css b/dashboard-client/app/app/src/index.css
index 685ac3c8b1..b360e095c7 100644
--- a/dashboard-client/app/app/src/index.css
+++ b/dashboard-client/app/app/src/index.css
@@ -16,6 +16,11 @@ body {
   -moz-osx-font-smoothing: grayscale;
 }
 
+a {
+  text-decoration: none;
+  color: blue;
+}
+
 code {
   font-family: source-code-pro, Menlo, Monaco, Consolas, "Courier New",
     monospace;
diff --git a/dashboard-client/app/yarn.lock b/dashboard-client/app/yarn.lock
new file mode 100644
index 0000000000..fb57ccd13a
--- /dev/null
+++ b/dashboard-client/app/yarn.lock
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+