gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client): errors with multiple editor tabs (#43549)

Browse Source 
* fix: enforce multifile tab order

* fix: sort challengeFiles to prevent remounts

If the challengeFiles are used unsorted, this can unmount an editor.
The editors rely on the mount hook for initialization, so extra mounts
can cause unwanted behaviour.

* fix: make editor tabs and panes match
This commit is contained in:
Oliver Eyton-Williams
2021-09-24 16:40:18 +02:00
committed by GitHub
parent 2abc2f6473
commit b5019000bb
4 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/sort-files.js
View File

@ -5,6 +5,8 @@ exports.toSortedArray = function toSortedArray(challengeFiles) {
xs.sort((a, b) => {
if (a.ext === 'html') return -1;
if (b.ext === 'html') return 1;
if (a.ext === 'css') return -1;
if (b.ext === 'css') return 1;
if (a.ext === 'jsx') return -1;
if (b.ext === 'jsx') return 1;
if (a.ext === 'js') return -1;

4
utils/sort-files.test.js
View File

@ -14,10 +14,10 @@ describe('sort-files', () => {
expect(sorted.length).toEqual(expected.length);
});
it('should sort the objects into html, js, css order', () => {
it('should sort the objects into html, css, jsx, js order', () => {
const sorted = challengeFiles;
const sortedKeys = sorted.map(({ fileKey }) => fileKey);
const expected = ['indexhtml', 'indexjsx', 'indexjs', 'indexcss'];
const expected = ['indexhtml', 'indexcss', 'indexjsx', 'indexjs'];
expect(sortedKeys).toStrictEqual(expected);
});
});