fix: negative sentiment → neutral language (#39522)

The existing terminology carries negative sentiment that can be
interpreted in a racial or sense. Updating the name to have no
potential for such a connection.

Co-authored-by: Justin Rogers <justrog@gmail.com>
This commit is contained in:
Mrugesh Mohapatra
2020-09-07 11:04:44 +05:30
committed by GitHub
parent b93785be5d
commit c23c4ef8e4
13 changed files with 40 additions and 34 deletions

View File

@ -40,7 +40,7 @@ describe('isValidUsername', () => {
});
it('rejects all other ASCII characters', () => {
const whiteList = ['-', '_', '+'];
const allowedCharactersList = ['-', '_', '+'];
const numbers = [48, 57];
const upperCase = [65, 90];
const lowerCase = [97, 122];
@ -50,7 +50,7 @@ describe('isValidUsername', () => {
for (let code = 0; code <= finalCode; code++) {
let char = String.fromCharCode(code);
let expected = invalidCharError;
if (whiteList.includes(char)) expected = validationSuccess;
if (allowedCharactersList.includes(char)) expected = validationSuccess;
if (inRange(code, numbers)) expected = validationSuccess;
if (inRange(code, upperCase)) expected = validationSuccess;
if (inRange(code, lowerCase)) expected = validationSuccess;