From c459572fcf7d4f0b936b6bb014592e6d25435081 Mon Sep 17 00:00:00 2001 From: Stuart Taylor Date: Mon, 25 Jun 2018 20:20:40 +0100 Subject: [PATCH] fix(about): Return empty object for no user (#17714) --- common/models/user.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/models/user.js b/common/models/user.js index 30035bdd3e..8b5ece6869 100644 --- a/common/models/user.js +++ b/common/models/user.js @@ -493,9 +493,7 @@ module.exports = function(User) { if (!username) { // Zalgo!! return nextTick(() => { - cb(new TypeError( - `username should be a string but got ${ username }` - )); + cb(null, {}); }); } return User.findOne({ where: { username } }, (err, user) => { @@ -503,7 +501,7 @@ module.exports = function(User) { return cb(err); } if (!user || user.username !== username) { - return cb(new Error(`no user found for ${ username }`)); + return cb(null, {}); } const aboutUser = getAboutProfile(user); return cb(null, aboutUser);