feat: remove protection from interview prep (#38136)

The interview prep section includes many challenges that require long
running calculations which can be mistaken for infinite loops. This
removes the loop protection from those challenges, while the tests are
being evaluated.

It keeps the protection for the preview, since it is easy to create
broken code while working on a challenge and that should not crash the
site.
This commit is contained in:
Oliver Eyton-Williams
2020-02-04 06:03:56 +01:00
committed by GitHub
parent 8b692560e8
commit c6eb40ceef
5 changed files with 53 additions and 30 deletions

View File

@@ -15,6 +15,7 @@ import escape from 'lodash/escape';
import {
challengeDataSelector,
challengeMetaSelector,
challengeTestsSelector,
initConsole,
updateConsole,
@@ -33,7 +34,8 @@ import {
getTestRunner,
challengeHasPreview,
updatePreview,
isJavaScriptChallenge
isJavaScriptChallenge,
isLoopProtected
} from '../utils/build';
// How long before bailing out of a preview.
@@ -67,7 +69,12 @@ export function* executeChallengeSaga() {
const proxyLogger = args => consoleProxy.put(args);
const challengeData = yield select(challengeDataSelector);
const buildData = yield buildChallengeData(challengeData);
const challengeMeta = yield select(challengeMetaSelector);
const protect = isLoopProtected(challengeMeta);
const buildData = yield buildChallengeData(challengeData, {
preview: false,
protect
});
const document = yield getContext('document');
const testRunner = yield call(
getTestRunner,
@@ -103,9 +110,9 @@ function* takeEveryConsole(channel) {
});
}
function* buildChallengeData(challengeData, preview) {
function* buildChallengeData(challengeData, options) {
try {
return yield call(buildChallenge, challengeData, preview);
return yield call(buildChallenge, challengeData, options);
} catch (e) {
yield put(disableBuildOnError());
throw e;
@@ -167,8 +174,14 @@ function* previewChallengeSaga() {
yield fork(takeEveryConsole, logProxy);
const challengeData = yield select(challengeDataSelector);
if (canBuildChallenge(challengeData)) {
const buildData = yield buildChallengeData(challengeData, true);
const challengeMeta = yield select(challengeMetaSelector);
const protect = isLoopProtected(challengeMeta);
const buildData = yield buildChallengeData(challengeData, {
preview: true,
protect
});
// evaluate the user code in the preview frame or in the worker
if (challengeHasPreview(challengeData)) {
const document = yield getContext('document');