gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: handle the sorting of transformed files (#44724)

Browse Source 
* fix: handle the sorting of transformed files

We can't use the ext property, since that is transformed, but the
history is maintained.

* test: make solutions polyVinyls for sorting

* refactor: inline prepareChallenge

* refactor: make solutions polys in getChallenges

* fix: convert each solution to a poly

* fix: skip empty solutions

* fix: get challenge file history in client

* refactor: stop calling isPoly from the client

* fix: remove debug console.log

* refactor: remove unnecessary sorting step
This commit is contained in:
Oliver Eyton-Williams
2022-01-24 19:42:27 +01:00
committed by GitHub
parent b1fb6adc39
commit cacc4eacd7
7 changed files with 37 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
curriculum/test/test-challenges.js
View File

@ -43,7 +43,6 @@ const testEvaluator =
const { getLines } = require('../../utils/get-lines');
const { isAuditedCert } = require('../../utils/is-audited');
const { sortChallengeFiles } = require('../../utils/sort-challengefiles');
const {
getChallengesForLang,
getMetaForBlock,
@ -533,9 +532,7 @@ ${inspect(commentMap)}
// TODO: the no-solution filtering is a little convoluted:
const noSolution = new RegExp('// solution required');
const solutionsAsArrays = solutions.map(sortChallengeFiles);
const filteredSolutions = solutionsAsArrays.filter(solution => {
const filteredSolutions = solutions.filter(solution => {
return !isEmpty(
solution.filter(
challengeFile => !noSolution.test(challengeFile.contents)