From cb0a502d82def2d5f4ed88ab2f7003425204edbb Mon Sep 17 00:00:00 2001 From: RobertoMSousa Date: Fri, 15 Oct 2021 08:43:43 +0100 Subject: [PATCH] chore: tree shaking - unused / redundant code (#43867) --- .eslintrc.json | 2 +- api-server/src/server/component-passport.js | 6 +----- api-server/src/server/utils/get-curriculum.js | 1 + client/src/components/Footer/index.tsx | 12 ------------ .../components/Header/components/auth-or-profile.tsx | 2 -- client/src/components/layouts/Default.js | 5 +---- client/src/pages/search.css | 5 ----- 7 files changed, 4 insertions(+), 29 deletions(-) delete mode 100644 client/src/pages/search.css diff --git a/.eslintrc.json b/.eslintrc.json index 72d8a12917..df1ce9fef6 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -35,7 +35,7 @@ "react": { "version": "16.4.2", "import/ignore": ["\\.json$"], - "import/extensions": [".js", ".jsx", ".tsx"] + "import/extensions": [".js", ".jsx", ".tsx", ".ts"] }, "import/ignore": ["node_modules"] }, diff --git a/api-server/src/server/component-passport.js b/api-server/src/server/component-passport.js index e8d9d087b5..5d7da3e42b 100644 --- a/api-server/src/server/component-passport.js +++ b/api-server/src/server/component-passport.js @@ -1,8 +1,4 @@ -// eslint-disable-next-line -import { - // prettier ignore - PassportConfigurator -} from '@freecodecamp/loopback-component-passport'; +import { PassportConfigurator } from '@freecodecamp/loopback-component-passport'; import dedent from 'dedent'; import passport from 'passport'; diff --git a/api-server/src/server/utils/get-curriculum.js b/api-server/src/server/utils/get-curriculum.js index e9968deedd..ef58ca84ce 100644 --- a/api-server/src/server/utils/get-curriculum.js +++ b/api-server/src/server/utils/get-curriculum.js @@ -6,6 +6,7 @@ import { flatten } from 'lodash'; // via the user object, then we should *not* store this so it can be garbage // collected. +// eslint-disable-next-line import/no-unresolved import curriculum from '../../../../config/curriculum.json'; export function getChallenges() { diff --git a/client/src/components/Footer/index.tsx b/client/src/components/Footer/index.tsx index 3d4a790a2e..7f7e8cc7e6 100644 --- a/client/src/components/Footer/index.tsx +++ b/client/src/components/Footer/index.tsx @@ -3,18 +3,6 @@ import { useTranslation } from 'react-i18next'; import Link from '../helpers/link'; import './footer.css'; -type ColHeaderProps = { - children: string | React.ReactNode | React.ReactElement; -}; - -// TODO: Figure out what ColHeader does: 'ColHeader' is declared but its value is never read. -// eslint-disable-next-line -const ColHeader = ({ children, ...other }: ColHeaderProps): JSX.Element => ( -
- {children} -
-); - function Footer(): JSX.Element { const { t } = useTranslation(); diff --git a/client/src/components/Header/components/auth-or-profile.tsx b/client/src/components/Header/components/auth-or-profile.tsx index 22334f5184..69903a824e 100644 --- a/client/src/components/Header/components/auth-or-profile.tsx +++ b/client/src/components/Header/components/auth-or-profile.tsx @@ -1,6 +1,4 @@ /* eslint-disable @typescript-eslint/ban-ts-comment */ -/* eslint-disable @typescript-eslint/no-unsafe-member-access */ -/* eslint-disable @typescript-eslint/no-unsafe-assignment */ // @ts-nocheck import React from 'react'; import { useTranslation } from 'react-i18next'; diff --git a/client/src/components/layouts/Default.js b/client/src/components/layouts/Default.js index 2873285999..94631471ae 100644 --- a/client/src/components/layouts/Default.js +++ b/client/src/components/layouts/Default.js @@ -32,11 +32,8 @@ import { flashMessageSelector, removeFlashMessage } from '../Flash/redux'; import Footer from '../Footer'; import Header from '../Header'; import OfflineWarning from '../OfflineWarning'; -// preload common fonts -// eslint-disable-next-line max-len -// eslint-disable-next-line max-len -// eslint-disable-next-line max-len +// preload common fonts import './fonts.css'; import './global.css'; import './variables.css'; diff --git a/client/src/pages/search.css b/client/src/pages/search.css deleted file mode 100644 index 7e793b7c52..0000000000 --- a/client/src/pages/search.css +++ /dev/null @@ -1,5 +0,0 @@ -.powered-by-wrapper { - display: flex; - justify-content: center; - align-items: center; -}