gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(a11y): remove unnecessary link on course heading (#44794)

Browse Source 
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
This commit is contained in:
Bruce B
2022-03-03 05:56:10 -08:00
committed by GitHub
parent 5368195e85
commit cef8e8f739
2 changed files with 7 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
client/src/templates/Introduction/components/block.tsx
View File

@ -169,12 +169,7 @@ export class Block extends Component<BlockProps> {
<ScrollableAnchor id={blockDashedName}> <ScrollableAnchor id={blockDashedName}>
<div className={`block ${isExpanded ? 'open' : ''}`}> <div className={`block ${isExpanded ? 'open' : ''}`}>
<div className='block-header'> <div className='block-header'>
<a className='block-link' href={`#${blockDashedName}`}> <h3 className='big-block-title'>{blockTitle}</h3>
<h3 className='big-block-title'>
{blockTitle}
<span className='block-link-icon'>#</span>
</h3>
</a>
{!isAuditedCert(curriculumLocale, superBlock) && ( {!isAuditedCert(curriculumLocale, superBlock) && (
<div className='block-cta-wrapper'> <div className='block-cta-wrapper'>
<Link <Link
@ -220,12 +215,7 @@ export class Block extends Component<BlockProps> {
<ScrollableAnchor id={blockDashedName}> <ScrollableAnchor id={blockDashedName}>
<div className='block'> <div className='block'>
<div className='block-header'> <div className='block-header'>
<a className='block-link' href={`#${blockDashedName}`}> <h3 className='big-block-title'>{blockTitle}</h3>
<h3 className='big-block-title'>
{blockTitle}
<span className='block-link-icon'>#</span>
</h3>
</a>
{!isAuditedCert(curriculumLocale, superBlock) && ( {!isAuditedCert(curriculumLocale, superBlock) && (
<div className='block-cta-wrapper'> <div className='block-cta-wrapper'>
<Link <Link

29
client/src/templates/Introduction/intro.css
View File

@ -19,15 +19,15 @@
flex-direction: row; flex-direction: row;
} }
.block-header .block-link { .block-header .big-block-title {
flex-grow: 3; flex-grow: 3;
flex-basis: 0; flex-basis: 0;
padding: 25px 15px 10px; padding: 25px 15px 10px;
} }
.block-link:hover, .big-block-title:hover,
.block-link:focus, .big-block-title:focus,
.block-link:active { .big-block-title:active {
background-color: var(--primary-background); background-color: var(--primary-background);
} }
@ -38,19 +38,6 @@ a.cert-tag:active {
background-color: var(--highlight-color); background-color: var(--highlight-color);
} }
.block-link {
cursor: pointer;
}
.block-link:hover .block-link-icon {
display: inline-block;
}
.block-link-icon {
display: none;
margin-left: 15px;
}
.big-block-title { .big-block-title {
font-size: 1.5rem; font-size: 1.5rem;
overflow-wrap: break-word; overflow-wrap: break-word;
@ -225,6 +212,7 @@ button.map-title {
.block-grid .map-title > svg:last-child { .block-grid .map-title > svg:last-child {
transform: rotate(180deg); transform: rotate(180deg);
margin-left: auto;
} }
.block-grid.open .map-title > svg:last-child { .block-grid.open .map-title > svg:last-child {
@ -363,9 +351,6 @@ button.map-title {
.block-grid .block-header { .block-grid .block-header {
flex-direction: column; flex-direction: column;
}
.block-grid .block-header {
display: flex; display: flex;
background: transparent; background: transparent;
border: none; border: none;
@ -390,10 +375,6 @@ button.map-title {
padding: 0 10px 10px; padding: 0 10px 10px;
} }
.block-grid .map-title > svg:last-child {
margin-left: auto;
}
.block-grid .map-title > svg { .block-grid .map-title > svg {
margin: 10px; margin: 10px;
} }