gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client): cert rendering temporarily (#43335)

Browse Source 
* fix: require login as step

* fix: cert rendering temporary

* fix: remove keys from other translation files

* fix: cypress test

* chore: shauns suggestions

* fix: remove steps

* fix: use a seperate UseEffect function

* Suggestions from Shaun

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: certification temp rendering

* fix: cert temp rendering hopefully

* fix: button visibility and cert test

* fix: condition

* test: improve claim cert tests

Without npm run seed, retries will be in a different state.

Check the scroll position to (hopefully) catch the weird cert claim bug.

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Sem Bauke
2021-10-01 06:30:14 +02:00
committed by GitHub
parent 3ea2fe4f77
commit cfc9b7258d
5 changed files with 84 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cypress/integration/learn/responsive-web-design/claim-cert-from-learn.js
View File

@ -49,6 +49,7 @@ describe('Responsive Web Design Superblock', () => {
});
describe('After submitting all 5 projects', () => {
before(() => {
cy.exec('npm run seed');
cy.login();
cy.toggleAll();
const { superBlock, block, challenges } = projects;
@ -82,6 +83,10 @@ describe('Responsive Web Design Superblock', () => {
cy.get('.donation-modal').should('not.exist');
// directed to claim-cert-block section
cy.url().should('include', '#claim-cert-block');
// make sure that the window has not snapped to the top (a weird bug that
// we never figured out and so could randomly reappear)
cy.window().its('scrollY').should('not.equal', 0);
cy.contains('Claim Your Certification');
cy.contains('Claim Certification').should('not.be.disabled').click();
cy.contains('Show Certification').click();
cy.location().should(loc => {