From 0e994d55c8f37285fd1f42ddff9309e2ad5e41c4 Mon Sep 17 00:00:00 2001 From: Samuel Plumppu Date: Tue, 31 Jan 2017 22:47:49 +0100 Subject: [PATCH] fix(challenge): Improve example for "Applied Visual Design: Use the u Tag to Underline Text". * Update instruction. * Update `challengeSeed` for following challenges. * Use strict equality for tests. --- .../applied-visual-design.json | 80 +++++++------------ 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/challenges/01-responsive-web-design/applied-visual-design.json b/challenges/01-responsive-web-design/applied-visual-design.json index 2a1868c807..e54bbdab47 100644 --- a/challenges/01-responsive-web-design/applied-visual-design.json +++ b/challenges/01-responsive-web-design/applied-visual-design.json @@ -407,7 +407,7 @@ "description": [ "To underline text, you can use the u tag. This is often used to signify that a section of text is important, or something to remember. With the u tag, the browser applies the CSS of text-decoration: underline; to the element.", "
", - "Wrap the u tag around the two anchor tags. It should not include the parent div that has the class of cardLinks.", + "Wrap the u tag around the text \"Ph.D. students\". It should not include the parent div that has the class of cardText.", "Note
Try to avoid using the u tag when it could be confused for a link. Anchor tags also have a default underlined formatting." ], "challengeSeed": [ @@ -451,9 +451,9 @@ "" ], "tests": [ - "assert($('u').length == 1, 'message: Your code should add a u tag to the markup.');", - "assert($('u').children('a').length == 2, 'message: The u tag should wrap around and contain the two a tags.');", - "assert($('u').children('div').length == 0, 'message: The u tag should not wrap around the parent div tag.');" + "assert($('u').length === 1, 'message: Your code should add a u tag to the markup.');", + "assert($('u').text().indexOf('Ph.D. students') > -1, 'message: The u tag should wrap around the text \"Ph.D. students\".');", + "assert($('u').children('div').length === 0, 'message: The u tag should not wrap around the parent div tag.');" ], "solutions": [], "hints": [], @@ -517,13 +517,11 @@ "
", "
", "

Google

", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", "
", "" @@ -594,13 +592,11 @@ "
", "
", "

Google

", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", "
", "" @@ -674,13 +670,11 @@ "
", "

GoogleAlphabet

", " ", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -758,13 +752,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -839,13 +831,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -924,13 +914,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -1012,13 +1000,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -1097,13 +1083,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", "" @@ -1196,13 +1180,11 @@ "
", "

Alphabet

", "
", - "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", + "

Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.

", "
", "
", - " ", - " Larry Page

", - " Sergey Brin", - " ", + " Larry Page

", + " Sergey Brin", "
", " ", ""