From d3f049451874d53b9394b43cf04bb04bdb29e934 Mon Sep 17 00:00:00 2001 From: Nawazish Ali Date: Wed, 9 Oct 2019 13:22:51 +0500 Subject: [PATCH] =?UTF-8?q?refactor(client):=20Nav=20logo=20to=20be=20serv?= =?UTF-8?q?ed=20as=20a=20React=20svg=20compone=E2=80=A6=20(#37136)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Refactor fccLogo to be served as a React svg component. * fix: brand naming conventions Co-authored-by: mrugesh --- client/src/assets/icons/freeCodeCampLogo.js | 24 +++++++++++++++++++ .../components/Header/components/NavLogo.js | 13 ++-------- .../Header/components/universalNav.css | 2 +- 3 files changed, 27 insertions(+), 12 deletions(-) create mode 100644 client/src/assets/icons/freeCodeCampLogo.js diff --git a/client/src/assets/icons/freeCodeCampLogo.js b/client/src/assets/icons/freeCodeCampLogo.js new file mode 100644 index 0000000000..12b5007686 --- /dev/null +++ b/client/src/assets/icons/freeCodeCampLogo.js @@ -0,0 +1,24 @@ +/* eslint-disable max-len */ +import React from 'react'; + +function freeCodeCampLogo() { + return ( + + + + + + ); +} + +freeCodeCampLogo.displayName = 'freeCodeCampLogo'; + +export default freeCodeCampLogo; diff --git a/client/src/components/Header/components/NavLogo.js b/client/src/components/Header/components/NavLogo.js index 87f7e6cdc3..7596a6f185 100644 --- a/client/src/components/Header/components/NavLogo.js +++ b/client/src/components/Header/components/NavLogo.js @@ -1,17 +1,8 @@ import React from 'react'; - -const fCClogo = 'https://s3.amazonaws.com/freecodecamp/freecodecamp_logo.svg'; +import freeCodeCampLogo from '../../../assets/icons/freeCodeCampLogo'; function NavLogo() { - return ( - - learn to code at freeCodeCamp logo - - ); + return ; } NavLogo.displayName = 'NavLogo'; diff --git a/client/src/components/Header/components/universalNav.css b/client/src/components/Header/components/universalNav.css index 29dc3811c3..a873f6717a 100644 --- a/client/src/components/Header/components/universalNav.css +++ b/client/src/components/Header/components/universalNav.css @@ -49,7 +49,7 @@ background-color: var(--theme-color); } -#universal-nav-logo img { +#universal-nav-logo svg { display: block; width: auto; height: 25px;