gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Switched the order of confirm password and ToS validation, in addition removed logical OR for checking username/password and assigning an empty string if username or password is undefined

Browse Source
This commit is contained in:
Sahat Yalkabov
2013-12-12 20:57:47 -05:00
parent beab17b9e8
commit debb395326
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
controllers/user.js
View File

@ -31,6 +31,9 @@ exports.postAccountProfile = function(req, res) {
// todo: change to change postPassword // todo: change to change postPassword
exports.postAccountSettings = function(req, res) { exports.postAccountSettings = function(req, res) {
console.log('okay!!'); console.log('okay!!');
// TODO: add new field "Existing password"
// TODO: validate if all passwords are matching
//TODO: change user's password
}; };
exports.deleteAccount = function(req, res) { exports.deleteAccount = function(req, res) {
@ -91,18 +94,20 @@ exports.postSignup = function(req, res) {
// TODO: add mongoose validation on ToS (virtual?) // TODO: add mongoose validation on ToS (virtual?)
// TODO: Mongoose virtual, move logic to model // TODO: Mongoose virtual, move logic to model
if (!req.body.tos) {
req.flash('messages', 'You must agree to terms and conditions');
return res.redirect('/signup');
}
if (req.body.password !== req.body.confirmPassword) { if (req.body.password !== req.body.confirmPassword) {
req.flash('messages', 'Passwords do not match'); req.flash('messages', 'Passwords do not match');
return res.redirect('/signup'); return res.redirect('/signup');
} }
if (!req.body.tos) {
req.flash('messages', 'You must agree to terms and conditions');
return res.redirect('/signup');
}
var user = new User({ var user = new User({
username: req.body.username || '', username: req.body.username,
password: req.body.password || '' password: req.body.password
}); });
user.save(function(err) { user.save(function(err) {