test: stop relying on curriculum dir structure

Also refactors path resolution a little
This commit is contained in:
Oliver Eyton-Williams
2020-08-31 14:19:19 +02:00
parent 9089ddca5c
commit df532099bc
2 changed files with 13 additions and 18 deletions

View File

@ -1,19 +1,11 @@
/* global expect beforeAll */
const {
challengesDir,
createChallengeCreator,
hasEnglishSourceCreator
} = require('./getChallenges');
/* eslint-disable max-len */
const REAL_PATH =
'01-responsive-web-design/applied-accessibility/add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md';
const REAL_MISSING_PATH =
'01-responsive-web-design/applied-accessibility/add-a-text-alternative-to-images-for-visually-impaired.md';
const EXISTING_CHALLENGE_PATH = 'challenge.md';
const MISSING_CHALLENGE_PATH = 'no/challenge.md';
/* eslint-enable max-len */
let hasEnglishSource;
let createChallenge;
@ -23,15 +15,15 @@ describe('create non-English challenge', () => {
describe('createChallenge', () => {
it('throws if lang is an invalid language', async () => {
createChallenge = createChallengeCreator(basePath, 'notlang');
await expect(createChallenge(REAL_PATH)).rejects.toThrow(
'notlang is not a accepted language'
);
await expect(
createChallenge(EXISTING_CHALLENGE_PATH, {})
).rejects.toThrow('notlang is not a accepted language');
});
it('throws an error if the source challenge is missing', async () => {
createChallenge = createChallengeCreator(challengesDir, 'chinese');
await expect(createChallenge(REAL_MISSING_PATH)).rejects.toThrow(
createChallenge = createChallengeCreator(basePath, 'chinese');
await expect(createChallenge(MISSING_CHALLENGE_PATH, {})).rejects.toThrow(
`Missing English challenge for
${REAL_MISSING_PATH}
${MISSING_CHALLENGE_PATH}
It should be in
`
);