From dfbf1ae9ae57eedfd4593b7a1c1bb4ccf6724705 Mon Sep 17 00:00:00 2001 From: Oliver Eyton-Williams Date: Fri, 19 Jun 2020 18:01:36 +0200 Subject: [PATCH] refactor(multi): DRY out view state changes --- client/src/templates/Challenges/classic/Editor.js | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/client/src/templates/Challenges/classic/Editor.js b/client/src/templates/Challenges/classic/Editor.js index 0d0410d977..5d3e1636c5 100644 --- a/client/src/templates/Challenges/classic/Editor.js +++ b/client/src/templates/Challenges/classic/Editor.js @@ -291,16 +291,12 @@ class Editor extends Component { this.setState({ fileKey: newFileKey }); const editor = this._editor; const currentState = editor.saveViewState(); - const currentModel = editor.getModel(); - if (currentModel === this.data.indexjs.model) { - this.data.indexjs.state = currentState; - } else if (currentModel === this.data.indexcss.model) { - this.data.indexcss.state = currentState; - } else if (currentModel === this.data.indexhtml.model) { - this.data.indexhtml.state = currentState; - } else if (currentModel === this.data.indexjsx.model) { - this.data.indexjsx.state = currentState; + + for (const key in this.data) { + if (currentModel === this.data[key].model) { + this.data[key].state = currentState; + } } editor.setModel(this.data[newFileKey].model);