Merge pull request #8894 from Bouncey/FIX/Comment-your-JavaScript-Code

FIX/Unfinished Function Declaration in Comments
This commit is contained in:
Stuart Taylor
2016-06-15 22:31:05 +01:00
committed by GitHub

View File

@ -5,6 +5,9 @@ window.common = (function(global) {
} = global; } = global;
const detectFunctionCall = /function\s*?\(|function\s+\w+\s*?\(/gi; const detectFunctionCall = /function\s*?\(|function\s+\w+\s*?\(/gi;
const detectInComment = new RegExp(['\\/\\/[\\W\\w\\s]*?function.|',
'\\/\\*[\\s\\w\\W]*?function',
'[\\s\\W\\w]*?\\*\\/'].join(''), 'gi');
const detectUnsafeJQ = /\$\s*?\(\s*?\$\s*?\)/gi; const detectUnsafeJQ = /\$\s*?\(\s*?\$\s*?\)/gi;
const detectUnsafeConsoleCall = /if\s\(null\)\sconsole\.log\(1\);/gi; const detectUnsafeConsoleCall = /if\s\(null\)\sconsole\.log\(1\);/gi;
@ -35,7 +38,8 @@ window.common = (function(global) {
if ( if (
code.match(/function/g) && code.match(/function/g) &&
!code.match(detectFunctionCall) !code.match(detectFunctionCall) &&
!code.match(detectInComment)
) { ) {
return Observable.throw( return Observable.throw(
new Error('SyntaxError: Unsafe or unfinished function declaration') new Error('SyntaxError: Unsafe or unfinished function declaration')