gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: order imports and remove circular dependencies (#41824)

Browse Source 
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
This commit is contained in:
Oliver Eyton-Williams
2021-08-02 15:39:40 +02:00
committed by GitHub
parent c7b27a53e7
commit e118dda13a
259 changed files with 1269 additions and 1303 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
curriculum/test/test-challenges.js
View File

@ -1,10 +1,20 @@
/* eslint-disable no-loop-func */
const path = require('path');
const { inspect } = require('util');
const vm = require('vm');
const { assert, AssertionError } = require('chai');
const jsdom = require('jsdom');
const liveServer = require('live-server');
const stringSimilarity = require('string-similarity');
const { isAuditedCert } = require('../../utils/is-audited');
const lodash = require('lodash');
const Mocha = require('mocha');
const mockRequire = require('mock-require');
const spinner = require('ora')();
const puppeteer = require('puppeteer');
const stringSimilarity = require('string-similarity');
// lodash-es can't easily be used in node environments, so we just mock it out
// for the original lodash in testing.
mockRequire('lodash-es', lodash);
const clientPath = path.resolve(__dirname, '../../client');
require('@babel/polyfill');
@ -16,50 +26,34 @@ require('@babel/register')({
ignore: [/node_modules/],
only: [clientPath]
});
const mockRequire = require('mock-require');
const lodash = require('lodash');
// lodash-es can't easily be used in node environments, so we just mock it out
// for the original lodash in testing.
mockRequire('lodash-es', lodash);
const createPseudoWorker = require('./utils/pseudo-worker');
const {
buildDOMChallenge,
buildJSChallenge
} = require('../../client/src/templates/Challenges/utils/build');
const {
default: createWorker
} = require('../../client/src/templates/Challenges/utils/worker-executor');
const { challengeTypes } = require('../../client/utils/challengeTypes');
// the config files are created during the build, but not before linting
/* eslint-disable import/no-unresolved */
const testEvaluator =
require('../../config/client/test-evaluator.json').filename;
/* eslint-enable import/no-unresolved */
const { assert, AssertionError } = require('chai');
const Mocha = require('mocha');
const { flatten, isEmpty, cloneDeep, isEqual } = lodash;
const { getLines } = require('../../utils/get-lines');
const { isAuditedCert } = require('../../utils/is-audited');
const jsdom = require('jsdom');
const vm = require('vm');
const puppeteer = require('puppeteer');
const { toSortedArray } = require('../../utils/sort-files');
const {
getChallengesForLang,
getMetaForBlock,
getTranslatableComments
} = require('../getChallenges');
const MongoIds = require('./utils/mongoIds');
const ChallengeTitles = require('./utils/challengeTitles');
const { challengeSchemaValidator } = require('../schema/challengeSchema');
const { challengeTypes } = require('../../client/utils/challengeTypes');
const { toSortedArray } = require('../../utils/sort-files');
const { testedLang } = require('../utils');
const {
buildDOMChallenge,
buildJSChallenge
} = require('../../client/src/templates/Challenges/utils/build');
const ChallengeTitles = require('./utils/challengeTitles');
const MongoIds = require('./utils/mongoIds');
const createPseudoWorker = require('./utils/pseudo-worker');
const { sortChallenges } = require('./utils/sort-challenges');
@ -67,13 +61,6 @@ const TRANSLATABLE_COMMENTS = getTranslatableComments(
path.resolve(__dirname, '..', 'dictionaries')
);
// the config files are created during the build, but not before linting
/* eslint-disable import/no-unresolved */
const testEvaluator =
require('../../config/client/test-evaluator.json').filename;
/* eslint-enable import/no-unresolved */
const { inspect } = require('util');
const commentExtractors = {
html: require('./utils/extract-html-comments'),
js: require('./utils/extract-js-comments'),
@ -82,6 +69,8 @@ const commentExtractors = {
scriptJs: require('./utils/extract-script-js-comments')
};
const { flatten, isEmpty, cloneDeep, isEqual } = lodash;
// rethrow unhandled rejections to make sure the tests exit with -1
process.on('unhandledRejection', err => handleRejection(err));