gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat: increate minimum challenge requirement AB test (#44764)

Browse Source 
* feat: increate minimum challenge requirement AB test

* fix: adjust tests

Co-authored-by: ahmad abdolsaheb <home@mac-16.local>
This commit is contained in:
Ahmad Abdolsaheb
2022-01-13 23:51:55 +03:00
committed by GitHub
parent 8f8a2cc0c5
commit e97920ae9c
6 changed files with 47 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
client/src/redux/index.js
View File

@@ -231,6 +231,7 @@ export const shouldRequestDonationSelector = state => {
const canRequestProgressDonation = state[MainApp].canRequestProgressDonation;
const isDonating = isDonatingSelector(state);
const recentlyClaimedBlock = recentlyClaimedBlockSelector(state);
const isAVariant = isAVariantSelector(state);
// don't request donation if already donating
if (isDonating) return false;
@@ -243,9 +244,17 @@ export const shouldRequestDonationSelector = state => {
// donations only appear after the user has completed ten challenges (i.e.
// not before the 11th challenge has mounted)
if (completedChallenges.length < 10) {
return false;
// the follwoing is an AB test for increasing the completed challenge requirement to 20
if (isAVariant) {
if (completedChallenges.length < 10) {
return false;
}
} else {
if (completedChallenges.length < 20) {
return false;
}
}
// this will mean we have completed 3 or more challenges this browser session
// and enough challenges overall to not be new
return completionCount >= 3;