gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: make all unhandled errors fail tests

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2020-08-27 12:00:25 +02:00
committed by Mrugesh Mohapatra
parent 0ccb140f71
commit e9bd88d245
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
curriculum/test/test-challenges.js
View File

@ -27,9 +27,6 @@ const { flatten } = require('lodash');
const jsdom = require('jsdom'); const jsdom = require('jsdom');
const dom = new jsdom.JSDOM('');
global.document = dom.window.document;
const vm = require('vm'); const vm = require('vm');
const puppeteer = require('puppeteer'); const puppeteer = require('puppeteer');
@ -57,6 +54,18 @@ const { createPoly } = require('../../utils/polyvinyl');
const testEvaluator = require('../../client/config/test-evaluator').filename; const testEvaluator = require('../../client/config/test-evaluator').filename;
// rethrow unhandled rejections to make sure the tests exit with -1
process.on('unhandledRejection', err => {
cleanup();
// setting the error code because node does not (yet) exit with a non-zero
// code on unhandled exceptions.
process.exitCode = 1;
throw err;
});
const dom = new jsdom.JSDOM('');
global.document = dom.window.document;
const oldRunnerFail = Mocha.Runner.prototype.fail; const oldRunnerFail = Mocha.Runner.prototype.fail;
Mocha.Runner.prototype.fail = function(test, err) { Mocha.Runner.prototype.fail = function(test, err) {
if (err instanceof AssertionError) { if (err instanceof AssertionError) {
@ -194,11 +203,6 @@ function cleanup() {
} }
function runTests(challengeData) { function runTests(challengeData) {
// rethrow unhandled rejections to make sure the tests exit with -1
process.on('unhandledRejection', err => {
throw err;
});
describe('Check challenges', function() { describe('Check challenges', function() {
after(function() { after(function() {
cleanup(); cleanup();