From 33d0faae24c4b1264903a55fef62931aa7086d7e Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 16 Aug 2015 18:26:11 +0100 Subject: [PATCH 1/3] Fixed a challenge test --- seed/challenges/object-oriented-and-functional-programming.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/object-oriented-and-functional-programming.json b/seed/challenges/object-oriented-and-functional-programming.json index 422ea277b6..7bd8ff8d1b 100644 --- a/seed/challenges/object-oriented-and-functional-programming.json +++ b/seed/challenges/object-oriented-and-functional-programming.json @@ -235,7 +235,7 @@ "tests":[ "assert.deepEqual(array, [1,2,3,4,5], 'You should have removed all the values from the array that are less than six');", "assert(editor.getValue().match(/array\\.filter\\(/gi), 'You should be using the filter method to remove the values from the array');", - "assert(editor.getValue().match(/\\[1\\,2\\,3\\,4\\,5\\,6\\,7\\,8\\,9\\,10\\]/gi), 'You should only be using .filter to modify the contents of the array);" + "assert(editor.getValue().match(/\\[1\\,2\\,3\\,4\\,5\\,6\\,7\\,8\\,9\\,10\\]/gi), 'You should only be using .filter to modify the contents of the array');" ], "challengeSeed":[ "var array = [1,2,3,4,5,6,7,8,9,10];", From 9c7b651827349377c85902b9008bbe0f76ef275a Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 16 Aug 2015 20:17:06 +0100 Subject: [PATCH 2/3] Fixed a challenge test on modify array data with indexes --- seed/challenges/basic-javascript.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/basic-javascript.json b/seed/challenges/basic-javascript.json index fa5c36c439..fa59afe650 100644 --- a/seed/challenges/basic-javascript.json +++ b/seed/challenges/basic-javascript.json @@ -513,7 +513,7 @@ ], "tests":[ "assert((function(){if(typeof(myArray) != 'undefined' && myArray[0] == 3 && myArray[1] == 2 && myArray[2] == 3){return(true);}else{return(false);}})(), 'myArray should now be [3,2,3]');", - "assert((function(){if(editor.getValue().match(/[0]/g).length >= 2 && editor.getValue().match(/=/g).length >= 2){return(true);}else{return(false);}})(), 'You should be using indexes to modify the values in myArray');" + "assert((function(){if(editor.getValue().match(/[0]/g).length >= 1 && editor.getValue().match(/=/g).length >= 2){return(true);}else{return(false);}})(), 'You should be using indexes to modify the values in myArray');" ], "challengeSeed":[ "var ourArray = [1,2,3];", From 0fd90f4aaf5a50007d5385d77fbbccece9287603 Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 16 Aug 2015 21:06:42 +0100 Subject: [PATCH 3/3] Fix #1790 --- seed/challenges/object-oriented-and-functional-programming.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/object-oriented-and-functional-programming.json b/seed/challenges/object-oriented-and-functional-programming.json index 7bd8ff8d1b..bf76f7ca77 100644 --- a/seed/challenges/object-oriented-and-functional-programming.json +++ b/seed/challenges/object-oriented-and-functional-programming.json @@ -227,7 +227,7 @@ "difficulty":0, "description":[ "filter is a useful method that can filter out values that don't match a certain criteria", - "Let's remove all the values less than six", + "Let's remove all the values greater than six", "array = array.filter(function(val) {", "  return(val<4);", "});"