gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12438 from BerkeleyTrue/fix/open-toggle-warning

Browse Source 
fix(nav): add noop for onToggle to remove warning
This commit is contained in:
Quincy Larson
2017-01-09 23:28:38 -06:00
committed by GitHub
parent 9928ff1792 f25d850c92
commit ed91c4bf09
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/app/components/Nav/Nav.jsx
View File

@ -10,6 +10,7 @@ import {
Navbar, Navbar,
NavbarBrand NavbarBrand
} from 'react-bootstrap'; } from 'react-bootstrap';
import noop from 'lodash/noop';
import navLinks from './links.json'; import navLinks from './links.json';
import AvatarPointsNavItem from './Avatar-Points-Nav-Item.jsx'; import AvatarPointsNavItem from './Avatar-Points-Nav-Item.jsx';
@ -90,6 +91,8 @@ export default class FCCNav extends React.Component {
} = this.props; } = this.props;
if (isDropdown) { if (isDropdown) {
// adding a noop to NavDropdown to disable false warning
// about controlled component
return ( return (
<NavDropdown <NavDropdown
id={ `nav-${content}-dropdown` } id={ `nav-${content}-dropdown` }
@ -99,6 +102,7 @@ export default class FCCNav extends React.Component {
onClose={ closeDropdown } onClose={ closeDropdown }
onMouseEnter={ openDropdown } onMouseEnter={ openDropdown }
onMouseLeave={ closeDropdown } onMouseLeave={ closeDropdown }
onToggle={ noop }
open={ isNavDropdownOpen } open={ isNavDropdownOpen }
title={ content } title={ content }
> >