gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tools: disable schema validation (#41300)

Browse Source 
Changes the schema validation script to print warnings to the
console instead of throwing errors. This will no longer cause CI
to fail on missing/extra/empty translation object keys.
This commit is contained in:
Nicholas Carrigan (he/him)
2021-02-28 10:35:21 -08:00
committed by GitHub
parent 2e752551dc
commit eda444a4ef
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
client/i18n/schema-validation.js
View File

@ -44,7 +44,7 @@ const findMissingKeys = (file, schema, path) => {
} }
} }
if (missingKeys.length) { if (missingKeys.length) {
throw new Error( console.warn(
`${path} is missing these required keys: ${missingKeys.join(', ')}` `${path} is missing these required keys: ${missingKeys.join(', ')}`
); );
} }
@ -65,7 +65,7 @@ const findExtraneousKeys = (file, schema, path) => {
} }
} }
if (extraKeys.length) { if (extraKeys.length) {
throw new Error( console.warn(
`${path} has these keys that are not in the schema: ${extraKeys.join( `${path} has these keys that are not in the schema: ${extraKeys.join(
', ' ', '
)}` )}`
@ -132,13 +132,13 @@ const translationSchemaValidation = languages => {
); );
const emptyKeys = noEmptyObjectValues(fileJson); const emptyKeys = noEmptyObjectValues(fileJson);
if (emptyKeys.length) { if (emptyKeys.length) {
throw new Error( console.warn(
`${language}/translation.json has these empty keys: ${emptyKeys.join( `${language}/translation.json has these empty keys: ${emptyKeys.join(
', ' ', '
)}` )}`
); );
} }
console.info(`${language} translation.json is correct!`); console.info(`${language} translation.json validation complete.`);
}); });
}; };
@ -160,13 +160,13 @@ const trendingSchemaValidation = languages => {
); );
const emptyKeys = noEmptyObjectValues(fileJson); const emptyKeys = noEmptyObjectValues(fileJson);
if (emptyKeys.length) { if (emptyKeys.length) {
throw new Error( console.warn(
`${language}/trending.json has these empty keys: ${emptyKeys.join( `${language}/trending.json has these empty keys: ${emptyKeys.join(
', ' ', '
)}` )}`
); );
} }
console.info(`${language} trending.json is correct!`); console.info(`${language} trending.json validation complete`);
}); });
}; };
@ -190,7 +190,7 @@ const motivationSchemaValidation = languages => {
); );
const emptyKeys = noEmptyObjectValues(fileJson); const emptyKeys = noEmptyObjectValues(fileJson);
if (emptyKeys.length) { if (emptyKeys.length) {
throw new Error( console.warn(
`${language}/motivation.json has these empty keys: ${emptyKeys.join( `${language}/motivation.json has these empty keys: ${emptyKeys.join(
', ' ', '
)}` )}`
@ -203,11 +203,9 @@ const motivationSchemaValidation = languages => {
object.hasOwnProperty('quote') && object.hasOwnProperty('author') object.hasOwnProperty('quote') && object.hasOwnProperty('author')
) )
) { ) {
throw new Error( console.warn(`${language}/motivation.json has malformed quote objects.`);
`${language}/motivation.json has malformed quote objects.`
);
} }
console.info(`${language} motivation.json is correct!`); console.info(`${language} motivation.json validation complete`);
}); });
}; };
@ -225,11 +223,11 @@ const introSchemaValidation = languages => {
findExtraneousKeys(fileKeys, introSchemaKeys, `${language}/intro.json`); findExtraneousKeys(fileKeys, introSchemaKeys, `${language}/intro.json`);
const emptyKeys = noEmptyObjectValues(fileJson); const emptyKeys = noEmptyObjectValues(fileJson);
if (emptyKeys.length) { if (emptyKeys.length) {
throw new Error( console.warn(
`${language}/intro.json has these empty keys: ${emptyKeys.join(', ')}` `${language}/intro.json has these empty keys: ${emptyKeys.join(', ')}`
); );
} }
console.info(`${language} intro.json is correct!`); console.info(`${language} intro.json validation complete`);
}); });
}; };
@ -249,13 +247,13 @@ const metaTagsSchemaValidation = languages => {
); );
const emptyKeys = noEmptyObjectValues(fileJson); const emptyKeys = noEmptyObjectValues(fileJson);
if (emptyKeys.length) { if (emptyKeys.length) {
throw new Error( console.warn(
`${language}/metaTags.json has these empty keys: ${emptyKeys.join( `${language}/metaTags.json has these empty keys: ${emptyKeys.join(
', ' ', '
)}` )}`
); );
} }
console.info(`${language} metaTags.json is correct!`); console.info(`${language} metaTags.json validation complete`);
}); });
}; };