From ee64ab97c1cb74b0bc06efd68c85a59be4503c0b Mon Sep 17 00:00:00 2001
From: Charles Moss <urlpanda@gmail.com>
Date: Mon, 18 Jun 2018 08:47:10 -0600
Subject: [PATCH] fix: removed unnecessary strip call from boot sequence
 (#17526)

fix: Updated boot/donate.js to connect to stripe by default in production mode

fix: removed whites spaces from donate.js and added extra check for api keys

fix: added a name to boot/donate.js export function
---
 server/boot/donate.js | 186 +++++++++++++++++++++++-------------------
 1 file changed, 102 insertions(+), 84 deletions(-)

diff --git a/server/boot/donate.js b/server/boot/donate.js
index 569464768a..9352367d3d 100644
--- a/server/boot/donate.js
+++ b/server/boot/donate.js
@@ -1,58 +1,63 @@
 import Stripe from 'stripe';
-
 import keys from '../../config/secrets';
 
-const stripe = Stripe(keys.stripe.secret);
+export default function donateBoot(app, done) {
 
-const subscriptionPlans = [500, 1000, 3500, 5000, 25000].reduce(
-  (accu, current) => ({
-    ...accu,
-    [current]: {
-      amount: current,
-      interval: 'month',
-      product: {
-        name:
-        'Monthly Donation to freeCodeCamp.org - ' +
-        `Thank you ($${current / 100})`
-      },
-      currency: 'usd',
-      id: `monthly-donation-${current}`
-    }
-  }),
-  {}
-);
-
-function createStripePlan(plan) {
-  stripe.plans.create(plan, function(err) {
-    if (err) {
-      console.log(err);
-      throw err;
-    }
-    console.log(`${plan.id} created`);
-    return;
-  });
-}
-
-stripe.plans.list({}, function(err, plans) {
-  if (err) {
-    throw err;
-  }
-  const requiredPlans = Object.keys(subscriptionPlans).map(
-    key => subscriptionPlans[key].id
-  );
-  const availablePlans = plans.data.map(plan => plan.id);
-  requiredPlans.forEach(planId => {
-    if (!availablePlans.includes(planId)) {
-      const key = planId.split('-').slice(-1)[0];
-      createStripePlan(subscriptionPlans[key]);
-    }
-  });
-});
-
-export default function donateBoot(app) {
+  let stripe = false;
   const { User } = app.models;
   const api = app.loopback.Router();
   const donateRouter = app.loopback.Router();
+  const subscriptionPlans = [500, 1000, 3500, 5000, 25000].reduce(
+    (accu, current) => ({
+      ...accu,
+      [current]: {
+        amount: current,
+        interval: 'month',
+        product: {
+          name:
+            'Monthly Donation to freeCodeCamp.org - ' +
+            `Thank you ($${current / 100})`
+          },
+          currency: 'usd',
+          id: `monthly-donation-${current}`
+      }
+    }), {}
+  );
+
+  function connectToStripe() {
+    return new Promise(function(resolve) {
+      // connect to stripe API
+      stripe = Stripe(keys.stripe.secret);
+      // parse stripe plans
+      stripe.plans.list({}, function(err, plans) {
+        if (err) {
+          throw err;
+        }
+        const requiredPlans = Object.keys(subscriptionPlans).map(
+          key => subscriptionPlans[key].id
+        );
+        const availablePlans = plans.data.map(plan => plan.id);
+        requiredPlans.forEach(planId => {
+          if (!availablePlans.includes(planId)) {
+            const key = planId.split('-').slice(-1)[0];
+            createStripePlan(subscriptionPlans[key]);
+          }
+        });
+      });
+      resolve();
+    });
+  }
+
+  function createStripePlan(plan) {
+    stripe.plans.create(plan, function(err) {
+      if (err) {
+        console.log(err);
+        throw err;
+      }
+      console.log(`${plan.id} created`);
+        return;
+      });
+  }
 
   function createStripeDonation(req, res) {
     const { user, body } = req;
@@ -64,8 +69,8 @@ export default function donateBoot(app) {
     const { amount, token: {email, id} } = body;
 
     const fccUser = user ?
-      Promise.resolve(user) :
-      User.create$({ email }).toPromise();
+            Promise.resolve(user) :
+            User.create$({ email }).toPromise();
 
     let donatingUser = {};
     let donation = {
@@ -79,43 +84,56 @@ export default function donateBoot(app) {
       user => {
         donatingUser = user;
         return stripe.customers
-        .create({
-          email,
-          card: id
-        });
-      })
-      .then(customer => {
-        donation.customerId = customer.id;
-        return stripe.subscriptions.create({
-          customer: customer.id,
-          items: [
-            {
-              plan: `monthly-donation-${amount}`
-            }
-          ]
-        });
-      })
-      .then(subscription => {
-        donation.subscriptionId = subscription.id;
-        return res.send(subscription);
-      })
-      .then(() => {
-        donatingUser.createDonation(donation).toPromise()
-          .catch(err => {
-            throw new Error(err);
+          .create({
+            email,
+            card: id
           });
-      })
-      .catch(err => {
-        if (err.type === 'StripeCardError') {
-          return res.status(402).send({ error: err.message });
-        }
-        return res.status(500).send({ error: 'Donation Failed' });
+    })
+    .then(customer => {
+      donation.customerId = customer.id;
+      return stripe.subscriptions.create({
+        customer: customer.id,
+        items: [
+          {
+            plan: `monthly-donation-${amount}`
+          }
+        ]
       });
+    })
+    .then(subscription => {
+      donation.subscriptionId = subscription.id;
+      return res.send(subscription);
+    })
+    .then(() => {
+      donatingUser.createDonation(donation).toPromise()
+        .catch(err => {
+          throw new Error(err);
+        });
+    })
+    .catch(err => {
+      if (err.type === 'StripeCardError') {
+        return res.status(402).send({ error: err.message });
+      }
+      return res.status(500).send({ error: 'Donation Failed' });
+    });
   }
 
-  api.post('/charge-stripe', createStripeDonation);
+  const pubKey = keys.stripe.public;
+  const secKey = keys.stripe.secret;
+  const secretInvalid = !secKey || secKey === 'sk_from_stipe_dashboard';
+  const publicInvalid = !pubKey || pubKey === 'pk_from_stipe_dashboard';
 
-  donateRouter.use('/donate', api);
-  app.use(donateRouter);
-  app.use('/external', donateRouter);
+  if (secretInvalid || publicInvalid) {
+    if (process.env.NODE_ENV === 'production') {
+      throw new Error('Stripe API keys are required to boot the server!');
+    }
+    console.info('No Stripe API keys were found, moving on...');
+    done();
+  } else {
+    api.post('/charge-stripe', createStripeDonation);
+    donateRouter.use('/donate', api);
+    app.use(donateRouter);
+    app.use('/external', donateRouter);
+    connectToStripe().then(done);
+  }
 }