chore: simplify eslint configuration (#44347)

* chore: extend import/recommended

* chore: use recommended lint rules

* refactor: apply lint rules

* chore: drop used config

client/i18n/schema-validation.js

@@ -202,7 +202,8 @@ const motivationSchemaValidation = languages => {
     if (
       !fileJson.motivationalQuotes.every(
         object =>
-          object.hasOwnProperty('quote') && object.hasOwnProperty('author')
+          Object.prototype.hasOwnProperty.call(object, 'quote') &&
+          Object.prototype.hasOwnProperty.call(object, 'author')
       )
     ) {
       console.warn(`${language}/motivation.json has malformed quote objects.`);

client/plugins/fcc-source-challenges/create-challenge-nodes.js

@@ -31,7 +31,6 @@ function createChallengeNode(challenge, reporter) {
     type: challenge.challengeType === 7 ? 'CertificateNode' : 'ChallengeNode'
   };
 
-  /* eslint-disable prefer-object-spread/prefer-object-spread */
   return JSON.parse(
     JSON.stringify(
       Object.assign(

client/plugins/fcc-source-challenges/gatsby-node.js

@@ -29,7 +29,7 @@ exports.sourceNodes = function sourceChallengesSourceNodes(
   }
   const { createNode } = actions;
   const watcher = chokidar.watch(curriculumPath, {
-    ignored: /(^|[\/\\])\../,
+    ignored: /(^|[/\\])\../,
     ignoreInitial: true,
     persistent: true,
     usePolling: true,

client/src/client/frame-runner.ts

@@ -62,7 +62,7 @@ async function initTestFrame(e: InitTestFrameArg = { code: {} }) {
     Object.freeze(o);
     Object.getOwnPropertyNames(o).forEach(function (prop) {
       if (
-        o.hasOwnProperty(prop) &&
+        Object.prototype.hasOwnProperty.call(o, prop) &&
         o[prop] !== null &&
         (typeof o[prop] === 'object' || typeof o[prop] === 'function') &&
         !Object.isFrozen(o[prop])

client/src/components/helpers/skeleton-sprite.tsx

@@ -2,10 +2,7 @@ import React from 'react';
 
 import styles from './skeleton-styles';
 
-// TODO: unsure about parameter typing
-function SkeletonSprite({}: React.FC<
-  React.ComponentPropsWithoutRef<'svg'>
->): JSX.Element {
+function SkeletonSprite(): JSX.Element {
   return (
     <div className='sprite-container'>
       <style dangerouslySetInnerHTML={{ __html: styles }} />

client/src/components/search/with-instant-search.tsx

@@ -109,7 +109,7 @@ function InstantSearchRoot({
         if (
           location.state &&
           typeof location.state === 'object' &&
-          location.state.hasOwnProperty('query')
+          Object.prototype.hasOwnProperty.call(location.state, 'query')
         ) {
           updateSearchQuery(location.state.query);
         } else if (location.search) {

client/src/templates/Challenges/utils/build.js

@@ -92,7 +92,7 @@ const buildFunctions = {
 
 export function canBuildChallenge(challengeData) {
   const { challengeType } = challengeData;
-  return buildFunctions.hasOwnProperty(challengeType);
+  return Object.prototype.hasOwnProperty.call(buildFunctions, challengeType);
 }
 
 export async function buildChallenge(challengeData, options) {

client/src/templates/Introduction/super-block-intro.tsx

@@ -122,7 +122,10 @@ const SuperBlockIntroductionPage = (props: SuperBlockProp) => {
     if (
       location.state &&
       typeof location.state === 'object' &&
-      location.state.hasOwnProperty('breadcrumbBlockClick')
+      Object.prototype.hasOwnProperty.call(
+        location.state,
+        'breadcrumbBlockClick'
+      )
     ) {
       return location.state.breadcrumbBlockClick;
     }