gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix(nav): Protect against missing data

Browse Source
This commit is contained in:
Berkeley Martinez
2016-08-04 15:01:37 -07:00
parent c3c640d00a
commit f0955aea5c
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/app/redux/load-current-challenge-saga.js
View File

@ -63,6 +63,10 @@ export function loadCurrentChallengeSaga(actions, getState) {
challengeIdToName[ currentChallengeId ] challengeIdToName[ currentChallengeId ]
]; ];
} }
// challenge data may not be set yet.
if (!finalChallenge.id) {
return Observable.empty();
}
if (finalChallenge.id === currentlyLoadedChallengeId) { if (finalChallenge.id === currentlyLoadedChallengeId) {
// don't reload if the challenge is already loaded. // don't reload if the challenge is already loaded.
// This may change to toast to avoid user confusion // This may change to toast to avoid user confusion

5
common/app/redux/selectors.js
View File

@ -22,6 +22,7 @@ export const firstChallengeSelector = createSelector(
) { ) {
return {}; return {};
} }
try {
return challengeMap[ return challengeMap[
blockMap[ blockMap[
superBlockMap[ superBlockMap[
@ -29,5 +30,9 @@ export const firstChallengeSelector = createSelector(
].blocks[0] ].blocks[0]
].challenges[0] ].challenges[0]
]; ];
} catch (err) {
console.error(err);
return {};
}
} }
); );