gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix show all bonfire bug where it wouldn't show while unauthenticated; add sr-only class to completed bonfires

Browse Source
This commit is contained in:
Michael Q Larson
2015-03-29 16:47:49 -07:00
parent 15728510ea
commit f0ae47dcf2
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
controllers/bonfire.js
View File

@ -12,10 +12,13 @@ var _ = require('lodash'),
*/ */
exports.showAllBonfires = function(req, res) { exports.showAllBonfires = function(req, res) {
var completedBonfires = req.user.completedBonfires.map(function(elem) { if(req.user) {
var completedBonfires = req.user.completedBonfires.map(function (elem) {
return elem._id; return elem._id;
}); });
} else {
completedBonfires = [];
}
var noDuplicateBonfires = R.uniq(completedBonfires); var noDuplicateBonfires = R.uniq(completedBonfires);
var data = {}; var data = {};
data.bonfireList = resources.allBonfireNames(); data.bonfireList = resources.allBonfireNames();

14
views/partials/bonfires.jade
View File

@ -11,14 +11,18 @@ h3
}) })
.success( .success(
function(data) { function(data) {
var docfrag = document.createDocumentFragment();
for (var i = 0; i < data.bonfireList.length; i++) { for (var i = 0; i < data.bonfireList.length; i++) {
var li = document.createElement('li'); var li = document.createElement("li");
var linkedName = getLinkedName(data.bonfireList[i].name); var linkedName = getLinkedName(data.bonfireList[i].name);
if (R.contains(data.bonfireList[i]._id, data.completedList)) { if (data.completedList.length > 0 && R.contains(data.bonfireList[i]._id, data.completedList)) {
$(li).html("<span class='sr-only'>completed</span><a href='/bonfires/" + linkedName + "'>" + data.bonfireList[i].name + "</a></li>");
$(li).addClass('strikethrough'); $(li).addClass('strikethrough');
} } else {
$(li).html("<a href='/bonfires/" + linkedName + "'>" + data.bonfireList[i].name + "</a></li>"); $(li).html("<a href='/bonfires/" + linkedName + "'>" + data.bonfireList[i].name + "</a></li>");
$(li).appendTo($('#bonfireList'));
} }
docfrag.appendChild(li);
};
$('#bonfireList').append(docfrag);
}); });