fix(settings): Removed link tag and added href into the button ta
The first button in the settings page no longer has a link tag so that the clickable area doesn't overflow outside of the button boundaries BREAKING CHANGE: none AFAIK Closes #17867
This commit is contained in:
committed by
Stuart Taylor
parent
2e04b0a1e7
commit
f13390acb3
@ -2,12 +2,9 @@ import PropTypes from 'prop-types';
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
import { connect } from 'react-redux';
|
import { connect } from 'react-redux';
|
||||||
import { createSelector } from 'reselect';
|
import { createSelector } from 'reselect';
|
||||||
|
|
||||||
import { Button } from 'react-bootstrap';
|
import { Button } from 'react-bootstrap';
|
||||||
|
|
||||||
import ns from './ns.json';
|
import ns from './ns.json';
|
||||||
import { FullWidthRow, Spacer, Loader } from '../../helperComponents';
|
import { FullWidthRow, Spacer, Loader } from '../../helperComponents';
|
||||||
import { Link } from '../../Router';
|
|
||||||
import AboutSettings from './components/About-Settings.jsx';
|
import AboutSettings from './components/About-Settings.jsx';
|
||||||
import InternetSettings from './components/Internet-Settings.jsx';
|
import InternetSettings from './components/Internet-Settings.jsx';
|
||||||
import EmailSettings from './components/Email-Settings.jsx';
|
import EmailSettings from './components/Email-Settings.jsx';
|
||||||
@ -77,16 +74,15 @@ export class Settings extends React.Component {
|
|||||||
return (
|
return (
|
||||||
<div className={ `${ns}-container` }>
|
<div className={ `${ns}-container` }>
|
||||||
<FullWidthRow>
|
<FullWidthRow>
|
||||||
<Link to={ `/${username}` }>
|
|
||||||
<Button
|
<Button
|
||||||
block={ true }
|
block={ true }
|
||||||
bsSize='lg'
|
bsSize='lg'
|
||||||
bsStyle='primary'
|
bsStyle='primary'
|
||||||
className='btn-link-social'
|
className='btn-link-social'
|
||||||
|
href={ `/${username}`}
|
||||||
>
|
>
|
||||||
Show me my public portfolio
|
Show me my public portfolio
|
||||||
</Button>
|
</Button>
|
||||||
</Link>
|
|
||||||
<Button
|
<Button
|
||||||
block={ true }
|
block={ true }
|
||||||
bsSize='lg'
|
bsSize='lg'
|
||||||
|
Reference in New Issue
Block a user