Render Hikes questions

common/app/redux/actions.js

@@ -4,10 +4,18 @@ import types from './types';
 // updateTitle(title: String) => Action
 export const updateTitle = createAction(types.updateTitle);
 
+let id = 0;
 // makeToast({ type?: String, message: String, title: String }) => Action
 export const makeToast = createAction(
   types.makeToast,
-  toast => toast.type ? toast : (toast.type = 'info', toast)
+  toast => {
+    id += 1;
+    return {
+      ...toast,
+      id,
+      type: toast.type || 'info'
+    };
+  }
 );
 
 // fetchUser() => Action

common/app/redux/reducer.js

@@ -10,10 +10,7 @@ export default handleActions(
 
     [types.makeToast]: (state, { payload: toast }) => ({
       ...state,
-      toast: {
+      toast
-        ...toast,
-        id: state.toast && state.toast.id ? state.toast.id : 1
-      }
     }),
 
     [types.setUser]: (state, { payload: user }) => ({ ...state, ...user }),

common/app/routes/Hikes/components/Hike.jsx

@@ -6,18 +6,15 @@ import { createSelector } from 'reselect';
 import Lecture from './Lecture.jsx';
 import Questions from './Questions.jsx';
 import { resetHike } from '../redux/actions';
+import { getCurrentHike } from '../redux/selectors';
 
 const mapStateToProps = createSelector(
-  state => state.hikesApp.hikes.entities,
+  getCurrentHike,
-  state => state.hikesApp.currentHike,
+  state => state.hikesApp.shouldShowQuestions,
-  state => state.hikesApp,
+  (currentHike, shouldShowQuestions) => ({
-  (hikes, currentHikeDashedName, { shouldShowQuestions }) => {
-    const currentHike = hikes[currentHikeDashedName];
-    return {
     title: currentHike ? currentHike.title : '',
     shouldShowQuestions
-    };
+  })
-  }
 );
 
 // export plain component for testing

common/app/routes/Hikes/components/Hikes.jsx

@@ -2,7 +2,7 @@ import React, { PropTypes } from 'react';
 import { compose } from 'redux';
 import { connect } from 'react-redux';
 import { Row } from 'react-bootstrap';
-import shouldComponentUpdate from 'react-pure-render/function';
+import PureComponent from 'react-pure-render/component';
 import { createSelector } from 'reselect';
 // import debug from 'debug';
 
@@ -15,13 +15,14 @@ import contain from '../../../utils/professor-x';
 // const log = debug('fcc:hikes');
 
 const mapStateToProps = createSelector(
-  state => state.hikesApp.hikes,
+  state => state.hikesApp.hikes.entities,
-  hikes => {
+  state => state.hikesApp.hikes.results,
-    if (!hikes || !hikes.entities || !hikes.results) {
+  (hikesMap, hikesByDashedName)=> {
+    if (!hikesMap || !hikesByDashedName) {
       return { hikes: [] };
     }
     return {
-      hikes: hikes.results.map(dashedName => hikes.entities[dashedName])
+      hikes: hikesByDashedName.map(dashedName => hikesMap[dashedName])
     };
   }
 );
@@ -36,7 +37,7 @@ const fetchOptions = {
   }
 };
 
-export class Hikes extends React.Component {
+export class Hikes extends PureComponent {
   static displayName = 'Hikes';
 
   static propTypes = {

common/app/routes/Hikes/components/Lecture.jsx

@@ -6,19 +6,18 @@ import { createSelector } from 'reselect';
 import debug from 'debug';
 
 import { toggleQuestionView } from '../redux/actions';
+import { getCurrentHike } from '../redux/selectors';
 
 const log = debug('fcc:hikes');
 
 const mapStateToProps = createSelector(
-  state => state.hikesApp.hikes.entities,
+  getCurrentHike,
-  state => state.hikesApp.currentHike,
+  (currentHike) => {
-  (hikes, currentHikeDashedName) => {
-    const currentHike = hikes[currentHikeDashedName];
     const {
       dashedName,
       description,
       challengeSeed: [id] = [0]
-    } = currentHike || {};
+    } = currentHike;
     return {
       id,
       dashedName,

common/app/routes/Hikes/components/Questions.jsx

@@ -10,8 +10,10 @@ import {
   releaseQuestion,
   grabQuestion
 } from '../redux/actions';
+import { getCurrentHike } from '../redux/selectors';
 
 const answerThreshold = 100;
+const springProperties = { stiffness: 120, damping: 10 };
 const actionsToBind = {
   answerQuestion,
   moveQuestion,
@@ -20,11 +22,10 @@ const actionsToBind = {
 };
 
 const mapStateToProps = createSelector(
-  state => state.hikesApp.hikes.entities,
+  getCurrentHike,
-  state => state.hikesApp.hikes.results,
   state => state.hikesApp,
   state => state.app.isSignedIn,
-  (hikesMap, hikesByDashname, ui, isSignedIn) => {
+  (currentHike, ui, isSignedIn) => {
     const {
       currentQuestion = 1,
       mouse = [ 0, 0 ],
@@ -34,7 +35,12 @@ const mapStateToProps = createSelector(
       shouldShakeQuestion = false
     } = ui;
 
+    const {
+      tests = []
+    } = currentHike;
+
     return {
+      tests,
       currentQuestion,
       isCorrect,
       mouse,
@@ -138,7 +144,7 @@ class Question extends React.Component {
   render() {
     const {
       tests = [],
-      mouse: [x],
+      mouse: [xPosition],
       currentQuestion,
       shouldShakeQuestion
     } = this.props;
@@ -158,7 +164,7 @@ class Question extends React.Component {
         xs={ 8 }
         xsOffset={ 2 }>
         <Row>
-          <Motion style={{ x: spring(x, { stiffness: 120, damping: 10 }) }}>
+          <Motion style={{ x: spring(xPosition, springProperties) }}>
             { questionElement }
           </Motion>
           <div className='spacer' />

common/app/routes/Hikes/redux/selectors.js

@@ -0,0 +1,8 @@
+// use this file for common selectors
+import { createSelector } from 'reselect';
+
+export const getCurrentHike = createSelector(
+  state => state.hikesApp.hikes.entities,
+  state => state.hikesApp.currentHike,
+  (hikesMap, currentHikeDashedName) => (hikesMap[currentHikeDashedName] || {})
+);